[Bug]: [Shadow] Shadow Crash (hurl) isn't suggested
Ragowit opened this issue · 5 comments
What version of HeroRotation are you using?
11.0.0.08
What version of HeroLib are you using?
11.0.0.05
What version of HeroDBC are you using?
11.0.0.01
What is the issue?
If you have the "Hurl" node for Shadow Crash so won't it ever be suggested by the addon. If you select the "Aim" node it works as intended.
Icon Behavior
None
Talent tree where it doesn't work: CIQAJSbRac/22NxZbHdYKOQzcMMDDDAAAAAAAAAAAAwYmFzYmZ2sxMzMzyglBzGzMzMmNGYMmxsY2mamBLYGAAAAAA
(And just change the choice node to Aim and it will work again)
This should now be fixed in commit ca80d9f. I'd failed to add the new spell ID for Shadow Crash.
Updated all addons (Rotation .09, Lib .06 and DBC .02), and now the addon doesn't work at all for me.
These are the errors I get:
Message: Interface/AddOns/HeroLib/Events/InFlight.lua:99: You forgot to register Shadow Crash for InFlight tracking.
Time: Tue Jul 30 10:15:29 2024
Count: 629
Stack: Interface/AddOns/HeroLib/Events/InFlight.lua:99: You forgot to register Shadow Crash for InFlight tracking.
[string "@Interface/AddOns/HeroLib/Events/InFlight.lua"]:99: in function <Interface/AddOns/HeroLib/Events/InFlight.lua:97>
[string "@Interface/AddOns/HeroRotation_Priest/Overrides.lua"]:113: in function `InFlight'
[string "@Interface/AddOns/HeroRotation_Priest/Shadow.lua"]:587: in function <Interface/AddOns/HeroRotation_Priest/Shadow.lua:582>
[string "@Interface/AddOns/HeroRotation_Priest/Shadow.lua"]:752: in function `?'
[string "@Interface/AddOns/HeroRotation/Main.lua"]:476: in function <Interface/AddOns/HeroRotation/Main.lua:455>
Locals: self = <table> {
InFlightEffectID = 205386
SpellTable = <table> {
}
LastDisplayTime = 145957.586000
}
Aura = nil
TrackedSpell = nil
TrackedSpells = <table> {
205385 = <table> {
}
}
Message: Interface/AddOns/HeroLib/Events/InFlight.lua:99: You forgot to register Shadow Crash for InFlight tracking.
Time: Tue Jul 30 10:14:33 2024
Count: 1584
Stack: Interface/AddOns/HeroLib/Events/InFlight.lua:99: You forgot to register Shadow Crash for InFlight tracking.
[string "@Interface/AddOns/HeroLib/Events/InFlight.lua"]:99: in function <Interface/AddOns/HeroLib/Events/InFlight.lua:97>
[string "@Interface/AddOns/HeroRotation_Priest/Overrides.lua"]:113: in function `InFlight'
[string "@Interface/AddOns/HeroRotation_Priest/Shadow.lua"]:330: in function <Interface/AddOns/HeroRotation_Priest/Shadow.lua:319>
[string "@Interface/AddOns/HeroRotation_Priest/Shadow.lua"]:341: in function <Interface/AddOns/HeroRotation_Priest/Shadow.lua:339>
[string "@Interface/AddOns/HeroRotation_Priest/Shadow.lua"]:749: in function `?'
[string "@Interface/AddOns/HeroRotation/Main.lua"]:476: in function <Interface/AddOns/HeroRotation/Main.lua:455>
Locals: self = <table> {
InFlightEffectID = 205386
SpellTable = <table> {
}
LastDisplayTime = 145876.470000
}
Aura = nil
TrackedSpell = nil
TrackedSpells = <table> {
205385 = <table> {
}
}
Message: Interface/AddOns/HeroLib/Events/InFlight.lua:99: You forgot to register Shadow Crash for InFlight tracking.
Time: Tue Jul 30 10:15:46 2024
Count: 295
Stack: Interface/AddOns/HeroLib/Events/InFlight.lua:99: You forgot to register Shadow Crash for InFlight tracking.
[string "@Interface/AddOns/HeroLib/Events/InFlight.lua"]:99: in function <Interface/AddOns/HeroLib/Events/InFlight.lua:97>
[string "@Interface/AddOns/HeroRotation_Priest/Overrides.lua"]:113: in function `InFlight'
[string "@Interface/AddOns/HeroRotation_Priest/Overrides.lua"]:83: in function `IsCastable'
[string "@Interface/AddOns/HeroRotation_Priest/Shadow.lua"]:671: in function <Interface/AddOns/HeroRotation_Priest/Shadow.lua:582>
[string "@Interface/AddOns/HeroRotation_Priest/Shadow.lua"]:752: in function `?'
[string "@Interface/AddOns/HeroRotation/Main.lua"]:476: in function <Interface/AddOns/HeroRotation/Main.lua:455>
Locals: self = <table> {
InFlightEffectID = 205386
SpellTable = <table> {
}
LastDisplayTime = 145957.586000
}
Aura = nil
TrackedSpell = nil
TrackedSpells = <table> {
205385 = <table> {
}
}
Message: Interface/AddOns/HeroLib/Events/InFlight.lua:99: You forgot to register Shadow Crash for InFlight tracking.
Time: Tue Jul 30 10:13:00 2024
Count: 16
Stack: Interface/AddOns/HeroLib/Events/InFlight.lua:99: You forgot to register Shadow Crash for InFlight tracking.
[string "@Interface/AddOns/HeroLib/Events/InFlight.lua"]:99: in function <Interface/AddOns/HeroLib/Events/InFlight.lua:97>
[string "@Interface/AddOns/HeroRotation_Priest/Overrides.lua"]:113: in function `InFlight'
[string "@Interface/AddOns/HeroRotation_Priest/Overrides.lua"]:83: in function `IsCastable'
[string "@Interface/AddOns/HeroRotation_Priest/Shadow.lua"]:310: in function <Interface/AddOns/HeroRotation_Priest/Shadow.lua:275>
[string "@Interface/AddOns/HeroRotation_Priest/Shadow.lua"]:732: in function `?'
[string "@Interface/AddOns/HeroRotation/Main.lua"]:476: in function <Interface/AddOns/HeroRotation/Main.lua:455>
Locals: self = <table> {
InFlightEffectID = 205386
SpellTable = <table> {
}
LastDisplayTime = 145741.292000
}
Aura = nil
TrackedSpell = nil
TrackedSpells = <table> {
205385 = <table> {
}
}
Maybe this ID is missing?
Made a new bug issue instead to track this new error. #1067