HeroRotation

HeroRotation

5M Downloads

Fire Mage Alpha [8.0.1.03] lua Error>> bool(firestarter.active)

Darkmoded opened this issue ยท 3 comments

commented

121x HeroRotation_Mage\Fire.lua:352: attempt to index global 'firestarter' (a nil value) HeroRotation_Mage\Fire.lua:352: in function ?'
HeroRotation\Main.lua:432: in function <HeroRotation\Main.lua:410>
Locals:
InCombatSkipped `

-- call_action_list,name=combustion_phase,if=cooldown.combustion.remains<=action.rune_of_power.cast_time+(!talent.kindling.enabled*gcd)&(!talent.firestarter.enabled|!firestarter.active|active_enemies>=4|active_enemies>=2&talent.flame_patch.enabled)|buff.combustion.up if (S.Combustion:CooldownRemainsP() <= S.RuneofPower:CastTime() + (num(not S.Kindling:IsAvailable()) * Player:GCD()) and (not S.Firestarter:IsAvailable() or not bool(firestarter.active) or Cache.EnemiesCount[40] >= 4 or Cache.EnemiesCount[40] >= 2 and S.FlamePatch:IsAvailable()) or Player:BuffP(S.CombustionBuff)) then local ShouldReturn = CombustionPhase(); if ShouldReturn then return ShouldReturn; end end

bool(firestarter.active) <<

commented

Related to https://github.com/herotc/hero-rotation-generator not handling firestarter

commented

I couldn't find a check to see if Firestarter was active on the target and changed it around to check the target health.
So
bool(firestarter.active)
became:
Target:HealthPercentage() > 90

commented

Hello,

this was already fixed 4 days ago in e9c2c22

Please make sure to update before reporting issues, especially for WIP specs, thank you.