HeroRotation

HeroRotation

Addons
5M Downloads

[Priest|Shadow] Shadow Word Death gets recommended even if not chosen

AISORTH opened this issue ยท 2 comments

commented

I assume because this line:

if S.ShadowWordDeath:IsCastableP() and (not Player:BuffP(S.VoidformBuff) or 
**(S.ShadowWordDeath:ChargesP() == 2 and Player:BuffStackP(S.VoidformBuff) < 15))** 
 and Target:HealthPercentage() < ExecuteRange()  then

   if HR.Cast(S.ShadowWordDeath) then return ""; end
    end

Shadow Word Death still gets recommended as a Shadow Priest even though the spell now became a talent choice on 75. *And even if it's not chosen as the talent of that tier.

Edit: Oh sorry, didn't see that you're not supposed to open issues for shadow. My bad :)!

commented

Proposed Change:

if S.ShadowWordDeath:IsCastableP() then
   if (not Player:BuffP(S.VoidformBuff) or (S.ShadowWordDeath:ChargesP() == 2 
    and  Player:BuffStackP(S.VoidformBuff) < 15)) and Target:HealthPercentage() < ExecuteRange()  then
     if HR.Cast(S.ShadowWordDeath) then return ""; end
  end
end

or something similar like that:

if S.ShadowWordDeath:IsCastableP() and (not Player:BuffP(S.VoidformBuff)) then
    if HR.Cast(S.ShadowWordDeath) then return ""; end
end

if S.ShadowWordDeath:isCastableP() and (S.ShadowWordDeath:ChargesP() == 2 
 and Player:BuffStackP(S.VoidformBuff) < 15) 
   and Target:HealthPercentage() < ExecuteRange() then
    if HR.Cast(S.ShadowWordDeath) then return ""; end
 end
commented

Fixed in 59184f5