HeroRotation

HeroRotation

5M Downloads

[Protection War] Defensive codes never called

jo32 opened this issue ยท 2 comments

commented
Defensive = function()
    -- Only worry about defensives if tanking
    if isCurrentlyTanking() then
      if S.ShieldBlock:IsReadyP() and (not (Player:Buff(S.ShieldBlockBuff)) or Player:BuffRemains(S.ShieldBlockBuff) <= gcdTime + (gcdTime * 0.5)) and 
        (not (Player:Buff(S.LastStandBuff))) and (Player:Rage() >= 30) then
          if HR.Cast(S.ShieldBlock, Settings.Protection.OffGCDasOffGCD.ShieldBlock) then return "shield_block defensive" end
      end
      if S.LastStand:IsCastableP() and (not Player:Buff(S.ShieldBlockBuff)) and Settings.Protection.UseLastStandToFillShieldBlockDownTime
        and (S.ShieldBlock:RechargeP() > (gcdTime * 2)) then
          if HR.Cast(S.LastStand, Settings.Protection.GCDasOffGCD.LastStand) then return "last_stand defensive" end
      end
      if Player:HealthPercentage() < 30 then
        if S.VictoryRush:IsReadyP() then
          if HR.Cast(S.VictoryRush) then return "victory_rush defensive" end
        end
        if S.ImpendingVictory:IsReadyP() then
          if HR.Cast(S.ImpendingVictory) then return "impending_victory defensive" end
        end
      end
    end
  end

this part of code never called

commented

I'll push a fix for this with my next update.

commented

Fixed in commit efaa6de