HeroRotation

HeroRotation

Addons
5M Downloads

[Protection War] Should not use shield block when is not currently tanking.

jo32 opened this issue ยท 3 comments

commented 
    if S.ShieldBlock:IsReadyP() and (S.ShieldSlam:CooldownUpP() and Player:BuffDownP(S.ShieldBlockBuff)) then
      if HR.Cast(S.ShieldBlock, Settings.Protection.OffGCDasOffGCD.ShieldBlock) then return "shield_block 64"; end
    end

consider adding isCurrentlyTanking() to codes mentioned above.

commented

SimC uses Shield Block for the dps increase to Shield Slam. I'll add a toggle option to only use Shield Block defensively.

commented

@Cilraaz I think casting ignore pain should also consider if currently tanking.

commented

Changed in commit efaa6de

Shield Block now has a "defensive use only" option toggle. Usage within the Aoe and St functions will obey the toggle option. Within the Defensive function, it will be suggested regardless.

I also added isCurrentlyTanking to Ignore Pain.