HeroRotation

HeroRotation

5M Downloads

Enhancement - Ascendance CD missing off-gcd option

Herdrage opened this issue ยท 6 comments

commented

Can someone implement this when able?

commented

Added toggle option to move Ascendance to OffGCD area in commit 7b9be5d

commented

Thanks for being so fast, I tried it though and it's not working right. It's not showing anything at a certain point, I believe it's at the point where it recommends ascendance in the rotation. It doesn't show anything in the main icon or off-gcd.

commented

The only change I made was adding the GCDasOffGCD option. It's disabled by default, however, so make sure you enable it in the settings.

commented

Here I'll show you what it's doing since that change. It shows all the other abilities fine but once it gets to ascendance it doesn't show anything and that's with the option on or off now. Before the change it did work fine as part of the main rotation icon. I noticed the elemental spec already had the off-gcd toggle option for it's ascendance, maybe that could be interfering with it somehow? I did try all combinations with both the ele and enh ascendance toggle just to see if that would change anything but it didn't.

WoWScrnShot_060419_142632

WoWScrnShot_060419_142647

commented

It looks like it was throwing a LUA error because Enhancement settings weren't defined as a variable, like spec settings usually are. It should be fixed in commit d3aa526

commented

Thanks it works perfect now.