Beast Mastery seems broken after recent changes
p4nchez opened this issue ยท 6 comments
Hi
it seems beast mastery is broken after one of the recent changes in the splash AOE thing or something other
"0cd6841 [Beast Mastery] Convert to HL Splash Data System - EvanMichaels"
the only suggesten i get is summon pet
nothing else
Survivel and MM work and show icons
If you are syncing to latest on HR you will also need to sync to latest on the Hero Lib core.
i have both latest alpha from twitch client (hero lib and hero rotation)
That issue was fixed almost immediately in herotc/hero-lib@d809771 so that change seems to be missing from your local version.
ok if i download both from latest master here on github no errors and working
but if i install latest alpha from twitch client i get this error
is twitch hero lib alpha not up2date?
ok i guess i know whats the problem is
twitch client maybe has some thing of delay or something
in twitch client latest alpha looks old
end
HL:RegisterForSelfCombatEvent(UpdateAbilityCache, "SPELL_DAMAGE");
HL:RegisterForPetCombatEvent(UpdateAbilityCache, "SPELL_DAMAGE");
end
but latest alpha from
https://wow.curseforge.com/projects/herolib/files
looks this
HL:RegisterForSelfCombatEvent(UpdateAbilityCache, "SPELL_DAMAGE", "SPELL_PERIODIC_DAMAGE");
HL:RegisterForPetCombatEvent(UpdateAbilityCache, "SPELL_DAMAGE");
so i guess you can close this because i didnt know that twitch client hast some kind of delay
but very strange twitch shows name of the latest working alpha