the following errors appeared in 8.0.2.00 release, worked stable in 8.0.1.12

1. When selected Elemental Spirits talent, the addon constantly throws the following exception:

[16:15:58] Interface\AddOns\HeroRotation_Shaman\Enhancement.lua:173: attempt to index global 'feral_spirit' (a nil value) 
[16:15:58] Interface\AddOns\HeroRotation_Shaman\Enhancement.lua:173: in function <Interface\AddOns\HeroRotation_Shaman\Enhancement.lua:171>
Interface\AddOns\HeroRotation_Shaman\Enhancement.lua:548: in function `?'
Interface\AddOns\HeroRotation\Main.lua:439: in function <Interface\AddOns\HeroRotation\Main.lua:417> 
[16:15:58] InCombatSkipped

2. When selected other 100-tier talent (Acendance in my case), the following exception sometimes is constantly thrown, reload fixes it for some time:

[16:23:27] Interface\AddOns\HeroRotation_Shaman\Enhancement.lua:507: attempt to index global 'essence' (a nil value) 
[16:23:27] Interface\AddOns\HeroRotation_Shaman\Enhancement.lua:507: in function `Priority'
Interface\AddOns\HeroRotation_Shaman\Enhancement.lua:558: in function `?'
Interface\AddOns\HeroRotation\Main.lua:439: in function <Interface\AddOns\HeroRotation\Main.lua:417> 
[16:23:27] InCombatSkipped

3. Feral Spirit and Ascendance are always shown in rotation (Ascendance only if the talent selected), both are never shown in Off GCD regardless the toggles value

• show as Off GCD: Feral Spirit [on/off]
• show as Off GCD: Ascendance [on/off]
• show Feral Spirit in rotation [on/off]

@Cilraaz
tested.
confirming issue 1 fix.
confirming issue 2 fix.
issue 3: both Ascendace and Sundering shows correctly in Off GCD, but not Feral Spirit.
Tested with both Ascendance and Elemental Spirits talents for 100-tier.
Tested in scenario where all other Off GCD skills were on CD so that Feral Spirit would show up.

Additional issue 4: noticed that with current release there are situations where

• I'm lacking Maelstorm resource
• Rockbiter skill has at least one charge available
• the current suggested skill icon (Stomrstrike/Lava Lash/Crash Lightning) is grayed-out
• Rockbiter is not suggested

Issue 3: Please double check your setting for Feral Spirit OffGCD. I was unable to replicate your issue and had Feral Spirit showing properly OffGCD. Please keep in mind that if more than 2 abilities are showing OffGCD, only the first two suggestions will show.

Issue 4: I committed a change to make all maelstrom-using abilities use IsReadyP instead of IsCastableP. This should fix the issue of unusable spells being suggested.

Issue 4: now fixed with the latest commit, though it's now often the case that there is no suggested skill, though it's understandable
Issue 3: Please refer to the screenshot attached. Wind Shear, Ascendace and Sundering all on CD, and Feral Spirit not showing as Off GCD. By the way its it's often the case that no skill is shown for Off GCD, sometimes the Off GCD skills appears for one suggested skill and then when skill is used they dissapear, and the appear again after 1-more used suggested skills. I have not noticed any pattern in this, though no 'Off GCD' skill is ever suggested at the beginnig of the fight.

Issue 3: You have "Show Feral Spirit in rotation" unchecked. So it will never show.

that clarifies a lot, thanks. I have misunderstood how those toggles work.

regarding the showing and not showing of the Off GCD skills, those screenshots were taken after each used suggested skills, they are ordered consecutively:

Can you provide the same screenshots, but with debug output enabled? There are multiple instances of Crash Lightning in the profile and it'd be easier to know which one is causing the potential issue.

there you go. tell me if you need anything else

Issue 1 is fixed in commit ffe93a1

Issue 2 is fixed in commit e3527bc

Issue 3 is fixed in commit 5ae85b8

If updating via the Twitch app, please set the addon to Release Type alpha to receive the latest updates.

The spells that are stopping OffGCD spells from showing are from action lists called before the CDs list that contains those OffGCD spells. Since they're finding a main icon spell to suggest, the profile never gets to the CDs list to find things like Feral Spirit.

If I've read the core code properly, a main icon Cast function call returns true, ending that iteration of the profile and starting a new one. Meanwhile, an OffGCD Cast or a CastSuggested returns false, allowing the profile to keep going in the search for a spell to suggest as the main icon.

All that to say that the behavior you're seeing is the correct behavior of the addon and Enhancement profile. There may be a good way to change this while keeping to the intent of the APL, but I'm not familiar enough with Enhancement to decide what change(s) would work.

should I create an enhancement request for this?

It's not so much an enhancement being required as it's just the order of the enhancement APL.