off GCD Essence Druid (Balance)

Question

off GCD Essence Druid (Balance)

Shashlic opened this issue 5 years ago · 5 comments

Shashlic commented 5 years ago

Hi Guys,

thx for your great work, i please you to fix one more thing.

My Moonkins Essence (exemple Condenced Live-Force) pop up in the Main Icon. Problem is, if you have to delay that DMG-CD it stays in the Main Icon unil use... and you can't see next spell.

Pls check Essence Option and give us a choice to show essences as OFF GCD.

Thx a lot!

Cilraaz · Answer 1 · 2019-09-01T15:44:18.000Z

Under the class settings is an option to change where the essences are displayed.

Shashlic · Answer 2 · 2019-09-07T14:40:07.000Z

Hi Cilraaz, unfortunately, I have to ask again how it behaves with the essences. With the owl/moonkin, the icon (setting does not matter) remains in the main window. Also for use trinkets. we have to delay our CDs with Lady Ashvein in the Eternal Palace and draw essences and DMG CDs round about 1 minute. Here, the display of Essence (Condensed Life Force) stops in the main window and blocks further attacks.We took screenshots. Maybe you can fix it like the BM hunter as an extra field to select? Thank you for your work and time! Best regards ... Shashlic

…

-----Original-Nachricht----- Betreff: Re: [herotc/hero-rotation] off GCD Essence Druid (Balance) (#494) Datum: 2019-09-01T17:44:22+0200 Von: "Cilraaz" <[email protected]> An: "herotc/hero-rotation" <[email protected]> Under the class settings is an option to change where the essences are displayed. —

Cilraaz · Answer 3 · 2019-09-07T18:43:22.000Z

Moonkin Form is only forced to the main icon if the option for showing Moonkin Form while out of combat is selected. Otherwise, it obeys the GCDasOffGCD setting.

Condensed Life-Force (as well as a few other essences/trinkets) is part of a CastCycle, which can't be moved to the OffGCD area. I've changed these to be normal casts instead, which will make them obey the setting. Please let me know if it acts as expected now.

This change is in commit 58184ca

Cilraaz · Answer 4 · 2019-09-09T17:54:36.000Z

The icon will now be wherever you've selected in the class options. There is a drop down for Essence Display Style, which all essences have been made to obey.

Shashlic · Answer 5 · 2019-09-09T15:12:25.000Z

Hi, the essence is no longer displayed in the main window, it worked fine. However, it is missing completely ^^. Crucible of flames (example) is displayed correctly. Maybe that can be corrected. Thank you for your help.

…

-----Original-Nachricht----- Betreff: Re: [herotc/hero-rotation] off GCD Essence Druid (Balance) (#494) Datum: 2019-09-07T20:43:31+0200 Von: "Cilraaz" <[email protected]> An: "herotc/hero-rotation" <[email protected]> Moonkin Form is only forced to the main icon if the option for showing Moonkin Form while out of combat is selected. Otherwise, it obeys the GCDasOffGCD setting. Condensed Life-Force (as well as a few other essences/trinkets) is part of a CastCycle, which can't be moved to the OffGCD area. I've changed these to be normal casts instead, which will make them obey the setting. Please let me know if it acts as expected now. This change is in commit 58184ca <58184ca> — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#494?email_source=notifications&email_token=AKEQGVYOKFMPUGB3QU6XJLTQIPY4ZA5CNFSM4ISXFNZKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6E7Q6A#issuecomment-529135736> , or mute the thread <https://github.com/notifications/unsubscribe-auth/AKEQGV3YFXQXEWT3HRIPG23QIPY4ZANCNFSM4ISXFNZA> . [ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "#494?email_source=notifications\u0026email_token=AKEQGVYOKFMPUGB3QU6XJLTQIPY4ZA5CNFSM4ISXFNZKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6E7Q6A#issuecomment-529135736", "url": "#494?email_source=notifications\u0026email_token=AKEQGVYOKFMPUGB3QU6XJLTQIPY4ZA5CNFSM4ISXFNZKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6E7Q6A#issuecomment-529135736", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

Share to