HeroRotation

HeroRotation

5M Downloads

[Unholy DK] Sacrificial Pact OffGCDasOffGCD vs GCDasOffGCD mismatch

wlfman57 opened this issue ยท 2 comments

commented

Line 293 tries to reference the GCDasOffGCD setting for sacrificial pact when it should reference OffGCDasOffGCD. This periodically causes errors and the rotation to disappear temporarily.

The Error Generated:
Message: Interface\AddOns\HeroRotation_DeathKnight\Unholy.lua:293: attempt to index field 'GCDasOffGCD' (a nil value)
Time: Tue Dec 8 20:54:05 2020
Count: 396
Stack: Interface\AddOns\HeroRotation_DeathKnight\Unholy.lua:293: attempt to index field 'GCDasOffGCD' (a nil value)
[string "=[C]"]: ?
[string "@interface\AddOns\HeroRotation_DeathKnight\Unholy.lua"]:293: in function <Interface\AddOns\HeroRotation_DeathKnight\Unholy.lua:238>
[string "@interface\AddOns\HeroRotation_DeathKnight\Unholy.lua"]:434: in function `?'
[string "@interface\AddOns\HeroRotation\Main.lua"]:445: in function <Interface\AddOns\HeroRotation\Main.lua:423>

Line 293 in Unholy.lua:
if HR.Cast(S.SacrificialPact, Settings.Commons.GCDasOffGCD.SacrificialPact, nil, not TargetIsInRange[8]) then return "sacrificial_pact cooldown 13"; end

Commons Section in Settings.lua:
Commons = {
UseDeathStrikeHP = 60, -- % HP threshold to try to heal with Death Strike
UseDarkSuccorHP = 80, -- % HP threshold to use Dark Succor's free Death Strike
UsePotions = true,
UseTrinkets = true,
TrinketDisplayStyle = "Suggested",
EssenceDisplayStyle = "Suggested",
CovenantDisplayStyle = "Suggested",
RaiseDeadDisplayStyle = "Suggested",
OffGCDasOffGCD = {
Trinkets = true,
Potions = true,
Racials = true,
MindFreeze = true,
DeathAndDecay = false,
SacrificialPact = true,
ArcaneTorrent = true
}

commented

Bump

commented

Fixed in commit 073fcbd