Poor Demon Spikes usage and Addon Threshold issues.
tamedbeast opened this issue ยท 9 comments
Demon Spikes health Threshold not working on the set value on the adjuster in the addon settings, it just blows both charges on full health, I would suggest having two thresholds for this since Demon spikes are used usually first charge 80% and second 40% approx for good measure.
Demon Spikes is currently suggested when there are greater than 1.9 charges (1 charge and 90% of the way through the 2nd charge's cooldown) or if the player's health is under the configurable threshold. It will not use both charges at full health.
That is wrong, it does use both demon spikes at 100% health, go test it on the test dummy, also demon spikes should not be called in till there is incoming damage, it would be a waste to use is anything above 90% health.
I main Vengeance. It does not.
I also main vengeance, and using 2 charges of demons spikes on full health is pointless.
Please provide the conditions under which this phenomenon occurs. I've never seen it, and the code should not allow for it.
Go to a test dummy in Stormwind and you can see if will recommend it while fighting the dummy that is literally doing no damage to you.
I have Demon Spikes set to OffGCD, so they're above the main icon. Here's 21 seconds on a dummy in Stormwind. It is suggested one time when at full or near-full charges.
You can see from mine the first ability it wanted to cast was demon spikes, then after it casts it still calls for it to be used, and this is at a training dummy at 100% health with no incoming dmg.
Demon Spikes is currently suggested when there are greater than 1.9 charges (1 charge and 90% of the way through the 2nd charge's cooldown) or if the player's health is under the configurable threshold. It will not use both charges at full health.
I see the exact same behavior: Suggesting DS when at full or near-full stacks. You originally stated that it suggested dumping both charges. Suggesting the one charge when it shouldn't is a very different potential issue.
Any defensives being suggested while not actively tanking should be resolved in commit 8965c98