HeroRotation

HeroRotation

5M Downloads

[UI] Keybinding detection problem

MrSmurfy opened this issue ยท 6 comments

commented

Hello,

I came across some weird keybind detection playing on my rogue.

For example:
image

Slice n Dice is bound to Control + 3 for me but the addon sometimes leaves out the modifier key.
I am not sure why it is doing that, I don't use any actionbar addon.

During stealth it doesn't show a keybind at all;
image

commented

Confirming - still an issue for rogues. Not only in stealth, btw. Probably has to do with bar switching when coming out of stealth.

commented

This should be fixed with the updates that you'd suggested in issue #849. If not, please let me know.

commented

Hey Cilraaz, glad to see you still working on the project! :) I hope you're doing well and everything is alright with Aethys.

Keybinds seem to work correctly throughout the normal rotation now. In stealth however it's still broken;

  • Opening from stealth it wants me to cast mutilate (assa rogue), the keybind for it is not being shown but I have mutilate in the same slot for my normal actionbar and my stealth actionbar.
  • for some reason it does show trinkets correctly when in stealth.

This is my stealth actionbar;
image

commented

The stealth one is being inconsistent it seems.. sometimes it works, sometimes it doesn't. I am trying to replicate it..

image

Okay so when the keybind isn't being detected from stealth I just simply move the mutilate to another slot and put it in slot1 again. Then the detection works again.

commented

I made a small change to HeroLib that may fix the issue. Please try commit herotc/hero-lib@75b86a9 and see if you still have the problem.

commented

I found a second issue that may also be affecting you. Please try commit herotc/hero-lib@ebbd8a3 which adds some changes for people using Blizzard default bars number 3 through 6.