HeroRotation

HeroRotation

5M Downloads

Condemn - wrong id's

c-ray-c opened this issue ยท 1 comments

commented

Currently, HeroRotation is never showing icon for Condemn due to wrong ids in the Warrior.lua.
GetSpellInfo("Condemn") returns id - 330334, but in the code it is:

Condemn = MultiSpell(330325, 317485),

Also, a question: wouldn't it be better to use GetSpellInfo by spell name to get the id instead of hardcoding them like that?

commented

This spell ID has been added in commit 733a3ab

We don't use GetSpellInfo, as that would break based on localization for all non-English clients.