HeroRotation

HeroRotation

5M Downloads

Missing event subscriptions causing key binds to not show up correctly for sub rogue

c-ray-c opened this issue ยท 2 comments

commented

Current (old) problem: for classes with bar swapping the keybinds may not always correctly show.
Sample: sub rogue, activating shadow dance swaps bar to the "stealth" one and then the key binds stop showing up (observed specifically for Eviscerate which is present on slot 3 both of the normal and "stealth" bars.

Looks like this change in the HeroLib fixes it (need to more testing but so far is looking good):

image

commented

After some quick testing, this seems to work fine, so the changes have been included in commit herotc/hero-lib@575cf61

commented

Also likely subscribing here to ACTIONBAR_SLOT_CHANGED is not a good idea, as it triggers for specific slot and we are handling that properly at line 143.