HeroRotation

HeroRotation

5M Downloads

[Warrior Arms] Thunderous Roar suggested before Test of Might

Exsol-bit opened this issue ยท 3 comments

commented

Thunderous Roar is suggested during Colossus Smash/Warbreaker (debuff on target), rather than after once Test of Might procs.

image
image

commented

Please enable debug output and let us know what it says when Thunderous Roar is suggested incorrectly.

commented

[Hero Rotation] thunderous_roar single_target 103

Shows up when testing both Test of Might & In For The Kill.

Changing line 299 to:

if CDsON() and S.ThunderousRoar:IsCastable() and (Player:BuffUp(S.TestofMightBuff) or (Player:BuffUp(S.TestofMightBuff) and Target:DebuffUp(S.ColossusSmashDebuff))) then

Resolved the issue, but I am almost certain anything after OR is redundant as both Test of Might & ColossusSmashDebuff can not be true at the same time.

commented

This should be fixed in commit e661940

The intent of that line is that Test of Might is active or not talented and Colossus Smash is up. That's been fixed.