Shadow Priest stops recommendations randomly in dungeons
GarrettCottrell opened this issue ยท 11 comments
The rotation works fine and then it just stops all recommendations for periods of time and then will start recommending again and then stop again etc
No. This is the first commit after 10.0.5.03's release. If you're comfortable modifying the files on your own, you can open HeroRotation_Priest\Priest.lua and modify line 135. Change:
DarkReveries = Spell(394963),
to
DarkReveriesBuff = Spell(394963),
That will resolve the issue.
Does it show a Pool icon or just disappear entirely? If the latter, it sounds like a lua error is occurring.
the behavior is akin to if someone was turning the addon off and then turning it back on - that's what the result was appearing like (I wasn't doing this obviosuly)
recommendations disappear entirely. I will change back to default plater profile (I was thinking, if nothing is seemingly wrong with the app it could be that my new profile for some reason isn't registering) but yeah recs disappear entirely and it almost never happens on st from the one dungeon I did (in that dungeon it never happened on a st boss but happened verrry frequently on trash pulls)
Looks like the behavior is also happening on the 5 target dummy in valdraaken (none of this was happening before the new patch)
I'm unable to replicate any issue, but my Priest is only 60. If the icon is disappearing entirely, there's a lua error. I would need that error to troubleshoot the issue.
okay, I changed plater profile - issue persisted. I'll turn on LUA errors and see if I can grab it
Message: Interface/AddOns/HeroLib/Class/Unit/Aura.lua:36: attempt to index local 'ThisSpell' (a nil value)
Time: Wed Jan 25 10:59:26 2023
Count: 706
Stack: Interface/AddOns/HeroLib/Class/Unit/Aura.lua:36: attempt to index local 'ThisSpell' (a nil value)
[string "=[C]"]: ?
[string "@Interface/AddOns/HeroLib/Class/Unit/Aura.lua"]:36: in function <Interface/AddOns/HeroLib/Class/Unit/Aura.lua:32>
[string "=(tail call)"]: ?
[string "@Interface/AddOns/HeroLib/Class/Unit/Aura.lua"]:101: in function BuffRemains' [string "@Interface/AddOns/HeroLib/Class/Unit/Aura.lua"]:119: in function
BuffUp'
[string "@Interface/AddOns/HeroRotation_Priest/Shadow.lua"]:565: in function <Interface/AddOns/HeroRotation_Priest/Shadow.lua:525>
[string "@Interface/AddOns/HeroRotation_Priest/Shadow.lua"]:660: in function `?'
[string "@Interface/AddOns/HeroRotation/Main.lua"]:455: in function <Interface/AddOns/HeroRotation/Main.lua:433>
Locals:
This has now been fixed in commit cfa3b56