[Bug]: DK Blood - BugSack reports thousands of errors
julienripet opened this issue · 2 comments
What version of HeroRotation are you using?
10.0.5.09
What version of HeroLib are you using?
10.0.5.02
What version of HeroDBC are you using?
10.0.5.02
What is the issue?
BugSack keeps throwing the following error
error
3849x HeroRotation_DeathKnight/Blood.lua:377: attempt to compare number with nil
[string "@HeroRotation_DeathKnight/Blood.lua"]:377: in function `?'
[string "@HeroRotation/Main.lua"]:455: in function <HeroRotation/Main.lua:433>
Locals:
ShouldReturn = nil
ShouldReturn = nil
(*temporary) = 53
(*temporary) = nil
(*temporary) = 53
(*temporary) = 72
(*temporary) =
UseCache = true
ChiDeficitPercentage = defined @HeroLib/Class/Unit/Player/Power.lua:595
GCDStartTime = defined @HeroLib/Class/Unit/Player/Stat.lua:70
Race = defined @HeroLib/Class/Unit/Player/Main.lua:45
Insanityrain = defined @HeroLib/Class/Unit/Player/Power.lua:647
FocusLossOnCastEnd = defined @HeroLib/Class/Unit/Player/Power.lua:226
PainMax = defined @HeroLib/Class/Unit/Player/Power.lua:724
IsInVehicle = defined @HeroLib/Class/Unit/Player/Main.lua:104
IsInParty = defined @HeroLib/Class/Unit/Player/Main.lua:32
EnergyDeficit = defined @HeroLib/Class/Unit/Player/Power.lua:279
Fury = defined @HeroLib/Class/Unit/Player/Power.lua:697
InstanceInfo = defined @HeroLib/Class/Unit/Player/Instance.lua:22
RageDeficit = defined @HeroLib/Class/Unit/Player/Power.lua:139
VersatilityDmgPct = defined @HeroLib/Class/Unit/Player/Stat.lua:119
ArcaneChargesDeficitPercentage = defined @HeroLib/Class/Unit/Player/Power.lua:680
MaelstromPercentage = defined @HeroLib/Class/Unit/Player/Power.lua:553
ArcaneCharges = defined @HeroLib/Class/Unit/Player/Power.lua:665
GetOnUseTrinkets = defined @HeroLib/Class/Unit/Player/Equipment.lua:30
IsInDungeonArea = defined @HeroLib/Class/Unit/Player/Instance.lua:53
ActiveMitigationNeeded = defined @HeroLib/Class/Unit/Player/Tank.lua:57
SoulShardsDeficit = defined @HeroLib/Class/Unit/Player/Power.lua:469
EssenceDeficit = defined @HeroLib/Class/Unit/Player/Power.lua:766
GetEnemiesInRange = defined @HeroLib/Class/Unit/Player/Enemies.lua:53
IsInWhitelistedVehicle = defined @HeroLib/Class/Unit/Player/Main.lua:140
PainDeficit = defined @HeroLib/Class/Unit/Player/Power.lua:739
AttackPower = defined @HeroLib/Class/Unit/Player/Stat.lua:78
FocusCastRegen = defined @HeroLib/Class/Unit/Player/Power.lua:208
PainDeficitPercentage = defined @HeroLib/Class/Unit/Player/Power.lua:744
PrevOffGCD = defined @HeroLib/Events/Prev_Spell.lua:236
MasteryPct = defined @HeroLib/Class/Unit/Player/Stat.lua:114
InsanityPercentage = defined @HeroLib/Class/Unit/Player/Power.lua:632
ManaDeficitPercentageP = defined @HeroLib/Class/Unit/Player/Power.lua:113
FuryDeficit = defined @HeroLib/Class/Unit/Player/Power.lua:707
PrevGCD = defined @HeroLib/Events/Prev_Spell.lua:202
AstralPowerMax = defined @HeroLib/Class/Unit/Player/Power.lua:481
IsMounted = defined @HeroLib/Class/Unit/Player/Main.lua:27
EnergyRegenPercentage = defined @HeroLib/Class/Unit/Player/Power.lua:289
RunicPowerDeficit = defined @HeroLib/Class/Unit/Player/Power.lua:389
FuryPercentage = defined @HeroLib/Class/Unit/Player/Power.lua:702
Insanity = defined @HeroLib/Class/Unit/Player/Power.lua:627
EnergyTimeToMaxPredicted = defined @HeroLib/Class/Unit/Player/Power.lua:336
ArcaneChargesPercentage = defined @HeroLib/Class/Unit/Player/Power.lua:670
AstralPowerDeficitPercentage = <function
It concerns this line I believe if S.DeathStrike:IsReady() and (Player:BuffRemains(S.CoagulopathyBuff) <= Player:GCD() or Player:BuffRemains(S.IcyTalonsBuff) <= Player:GCD() or Player:RunicPower() <= VarDeathStrikeDumpAmt or Player:RunicPowerDeficit() <= VarHeartStrikeRP or Target:TimeToDie() < 10) then, but I'm not sure which part exactly
Icon Behavior
N/A
This should be resolved in commit 3271e8d
Please let us know if it's still a problem after applying that change (via either update from github or when the next version is released).