HeroRotation

HeroRotation

5M Downloads

[Bug]: (subtlety): Cold Blood / Secret Technique / Dance Macabre Interaction

Furizaa opened this issue ยท 4 comments

commented

What version of HeroRotation are you using?

head

What version of HeroLib are you using?

head

What version of HeroDBC are you using?

head

What is the issue?

Not sure if it is even a bug or what exactly is the cause for this, but the sims always hold Cold Blood for Secret Technique, while the addon uses Cold Blood for Eviscerate.

image

image

Reproduction

  • Talent Cold Blood, Secret Technique, Dance Macabre
  • Unselect "Show Off GCD as off GCD: Cold Blood" in the addon
  • Do Rotation

Workaround

  • Select "Show Off GCD as off GCD: Cold Blood" in the addon, ignore suggestion
  • Macro Cold Blood to Secret Technique

Icon Behavior

None

commented

Haven't really seen this myself and the code specifically checks for SecTec in this regard.

  -- actions.cds+=/cold_blood,if=!talent.secret_technique&combo_points>=5
  if S.ColdBlood:IsReady() and not S.SecretTechnique:IsAvailable() and ComboPoints >= 5 then
    if HR.Cast(S.ColdBlood, Settings.Commons.OffGCDasOffGCD.ColdBlood) then return "Cast Cold Blood" end
  end

The line that is printing above "Cast Cold Blood" shouldn't be running if you have SecTec talented.

commented

Not able to replicate this either;
image
image
image

commented

I believe it comes from this line which returns CB as ReturnSpellOnly.

It then hits the actual CastPooling here:

if HR.CastPooling(PoolingAbility) then return "Stealthed Cast " .. PoolingAbility:Name() end

But if you can't reproduce it then I believe you and you can close it :D I'll try to do a fresh setup before the season hits.

@mhunk It doesn't seem to cast Cold Blood at all for you. Do you perhaps have Show Off GCD as off GCD: Cold Blood selected?

commented

those original screenshots were with OGCD enabled. but it not recommending it i think is by design, your expected to have CB macro'd into SecTech.

Here's the logs with OGCD disabled;

image