HeroRotation

HeroRotation

Addons
6M Downloads

[Survival]: Djaruun is not suggested

Zonarius opened this issue · 1 comments

commented

What version of HeroRotation are you using?

10.1.0.07

What version of HeroLib are you using?

10.1.0.02

What version of HeroDBC are you using?

10.0.7.02

What is the issue?

First of all thanks for your work on this addon. I really like the code style. Very functional, straight forward and easy to understand.

I'm a lucky survival hunter who got the polearm Djaruun on normal yesterday and noticed that HeroRotation does not suggest using the on-use effect.

I believe the reason is that simc summarizes all item usages with use_items:

https://github.com/simulationcraft/simc/blob/dragonflight/profiles/Tier30/T30_Hunter_Survival.simc#LL52C32-L52C32

However, HeroRotation (or at least the surv hunter rotation) uses Player:GetUseableTrinkets:

hero-rotation/HeroRotation_Hunter/Survival.lua

Lines 215 to 219 in a56c20b

-- use_items,use_off_gcd=1,if=gcd.remains>gcd.max-0.1&!buff.spearhead.up
local TrinketToUse = Player:GetUseableTrinkets(OnUseExcludes)
if TrinketToUse then
if Cast(TrinketToUse, nil, Settings.Commons.DisplayStyle.Trinkets) then return "Generic use_items for " .. TrinketToUse:Name(); end
end

Which, as the name suggests, does not use items other than trinkets.

I have made a workaround here:
Zonarius@5803647

This works, but it would be better to have a Player:GetUsableItems function and use that instead.

Icon Behavior

None

commented

Djaruun handling added in commit 0f59479

  • ❤️1