Can't hide "expansion name" factions
SirJorb opened this issue ยท 21 comments
Yeah I'm not sure whats going on with those headers. I'm waiting for a chance to get on the 10.0.5 PTR to see if they're fixing it.
Bug seems to be fixed on the 10.0.5PTR. Will add Valdrakken Accord support with the 10.0.5 patch.
This issue is still happening, as well as the valdrakken accord one.
Can you show me a screeny of your reputations containing the problematic ones
I think I've determined at least part of what causes the issue, though I'm not sure if it's an issue with the game client or the addon -
It's the categories for reptuations being displayed as reps themselves.
For example, on my main I have these ones still:
I currently have all the reps for Cata and TBC marked as inactive, because I've finished them. But if I unmark one...
Have you updated the addon? I fixed those ones a few days ago. Is it turned on? All of those should work.
Apologies, yeah it wasn't turned on.
The reason I'd turned it off, is because of another issue that I think has been caused by using this addon.
When loading the addon, it just doesn't allow any interaction with the reputation pane, and no expansion titles open.
When loading without the addon, it looks like this (with "Battle for Azeroth" near the bottom):
When you click on the "Battle for Azeroth" title it now looks like this, (I've made all Battle for Azeorth factions inactive except for "Champions of Azeorth")
When I untick all the "Battle for Azeroth" factions from being inactive, it looks like this:
Notice that the "Battle for Azeorth" title has disappeared
So it looks like I've managed to hide the "Battle for Azeorth" dropdown somehow, and I believe it was by using this addon. Any idea how to fix this, as it's broken even when I don't have any addons active.
Yeah, all the pictures above are without the addon turned on.
Do you know if there is a file where it is recorded which reputations you have set to be hidden for each character?
They're hidden on Blizzards end. For some reason they've made those headers able to be marked hidden, even though you don't get an option. I'll try and find a way to un-hide them again.
They've made those expansion headers hideable - but not the subheaders like Ember Court!
Oh that's helpful of Blizzard! XD
Thanks for checking into this.
If it helps, I think I was sort of spam clicking to try and hide everthing from older expansions as quickly as possible. At one point I hid something that made everything start to look a little weird, so I stopped.
I now think I was somehow able to hide that "Battle for Azeorth" expansion header
So that seems to have fixed the issue with "Battle for Azeroth" expansion header disappearing as it's back now in its proper place:
However, when I was turning factions inactive and active again to make sure it works, I managed to get it stuck unresponsive, and when I reloaded the game, it then looked like this:
From checking a few more times, it looks like if you have the addon turned on, and turn all "inactive" factions back to "active" (so the "Inactive" header should usually disappear) it then seems to break the addon.
I can make the addon work again by turning it off, making any faction inactive, and turning the addon back on again.
I was able to reproduce this while having all other addons turned off.
It wasn't working properly with empty Inactive lists. This fix should make it work when there is one other faction in the Inactive list. However, I cannot add the Inactive header if it is not already there. So if you have nothing marked Inactive, then you mark Horde Expedition inactive, you won't be able to see it anywhere to unmark it until you mark something else inactive. A faction that can normally be marked inactive.
Looks like the inactive header issue is fixed now.
While trying to check this is working, I had a few issues with making "Valdrakken Accord" inactive and active. Sometimes needed to click the button multiple times, or reload the game to make it work.
It's nothing majort though, and I was able to make it work, but it was a little confusing and not working as expected (one click either way).
Tried this with other factions being hidden at the same time too.
Sometimes you will have to scroll your mouse wheel a bit to make it update. The UI has some issues with not accepting my changes immediately.
Releasing an overhaul to the internal workings of the addon. Should be no practical difference to everyday use, it just should be much more responsive to changes now, and (hopefully) stop causing conflicts with other addons.
If you have any new issues as a result of todays changes, please create a new ticket.