ItemRack Classic

ItemRack Classic

7M Downloads

FD trinket swap broken after update

perks opened this issue ยท 12 comments

commented

Hey, after the update change to autoqueing, autoqueing trinkets for swap during FD no longer seems to trigger.

commented

Yeah I downgraded to 3.40 and it started working again. Tried toggling the "auto queue this slot" after a /reload and also exiting and reinstalling the addon in a fresh session.

commented

Hey

  • Did it work with 3.40 or which version did work for you?
  • Did you check "Auto queue this slot" for the item after 3.40?
commented

Ill try to get some recordings posted tonight!

commented

Are you able to reproduce this while recording it?

commented

Very nice to hear that the issue is fixed.
I wonder if we should add some kind of migration for such things in the future.im closing the issue now.
Thanks for your help!

commented

Please download the latest master from https://github.com/Rottenbeer/ItemRack and check if it works with this version.
It's published now also on curseforge (3.43)

commented

So it seems to only be effecting the second slot. I tried with the update and the same behaviour occurs -- i included a different trinket to see whether it was the new trinket from ZG that causes this but didnt seem so. I am running a weak aura that lets me know if FD is resisted (also combat text displays drop of combat).

3.40 both slots working: https://streamable.com/ohkrxf
3.42 not working: https://streamable.com/tmemm6
3.43 not working: https://streamable.com/hl4fwz
3.43 different trinket not working: https://streamable.com/8k8nb0

Thanks for taking the time to triage this!

Edit: on 3.40 the "Pause Queue" for the trinket is selected in the slot, i've since removed this via testing on later versions (as you can see in the videos) and also removed it from 3.40 testing and it still works

Should note that i am using https://github.com/RagedUnicorn/wow-classic-gearmenu for manual swapping, quickchange slots but any autoqueue functionality is disabled (3.40 also seems to work with gearmenu)

commented

Did you uncheck and re-check the "Auto queue this slot" option at any point after the upgrade to the new version? If not, that could cause issues.
Will see if I can spot anything further though.

If you alt+click your trinket slot in the character screen, it will give you a trinket widget, this should show if trinkets are queued for swap with an icon in the top left corner of the widget.

commented

I did toggle it a couple of times when testing

When enabling itemrack's queue swap here is what is appearing:
image

So top slot is correctly showing the icon of a trinket to swap to, where as the bottom slot only shows a gear

A manual queue works perfectly fine

commented

Can you alt+click the bottom slot widget so the cog gets removed and re-added?
The swap should also work out of combat if the current equipped trinket is on cd.

commented

@blastehh @Rottenbeer it seems removing and re-adding the slot fixes this issue!

commented

I'm 99% sure that this was because your settings carried over from 3.40 where the value for the checkbox was incorrect. Toggling it gives it the correct value.