ItemVersion

ItemVersion

Addons
216k Downloads

[suggestion] Add the Command key (Mac) as option to the tooltip modifier keys

tflo opened this issue · 8 comments

commented

What version of ItemVersion are you running?

2022.47.2

What is your issue?

Thanks for adding the tooltip modifier keys.

For us Mac users, it would be nice to have the option to set the Command key as modifier for the tooltip, as this is our main modifier and in best thumb position.

For details how to do this (it is really easy), please see my post for ATT, which is a very similar case. (Or Leatrix.).

This is for WoW Retail. I currently don't play Classic, so I don't know if it will work there. (I have one WotLK Classic toon though, so I could test it.)

Thanks in advance for considering,

– Tom

Can you provide any screenshots of what you describe?

n/a

commented

Just noticed that your addon is fully built on Ace libraries, including config. So it seems you are the wrong addressee in this case. (Somewhat surprised that they still have not added the modifier.)

PS: Posted in the Ace Issues now.

commented

I do think this is possible without a fix from Ace. I'm not using any of their API to do the modifier detection or configuration.

I didn't know there was a meta modifier function until I read your linked post: IsMetaKeyDown(). I think I can incorporate that right into this area:

ItemVersion/ItemVersion/Tooltip.lua

Line 22 in e243f08

function ItemVersion:ConfiguredModifiersAreDown()

Configuration takes place here:

ItemVersion/ItemVersion/Options.lua

Lines 202 to 214 in e243f08

keyModifiers = {
type = "multiselect",
order = 30,
name = L["Modifier keys"],
desc = L[
"Display the tooltip only when the selected modifier keys being are " ..
"pressed. (No selections means always show.)"
],
values = { shift = L["SHIFT"], control = L["CONTROL"], alt = L["ALT"] },
set = function(_, key, value) self.db.profile.keyModifiers[key] = value end,
get = function(...) return self.db.profile.keyModifiers[select(-1, ...)] end,
width = "full",
},

I'll start working on this soon. Because I'm on Windows, would you be willing to give me feedback on how it works for Mac users after I commit it?

commented

Well, if you can add the modifier without hooking into the Ace stuff, that would be great of course. (When I saw the AceConfig lib and that the modifier is completely missing there, I gave up ;)

would you be willing to give me feedback on how it works for Mac

Sure. This is not the first addon where I annoy the author with that suggestion. Dominos, Clicked, LeatrixPlus, ATT were before you ;)

commented

I'm not sure if you saw it in the linked instructions in the OP: You can test for the Mac platform with IsMacClient(). That means you can conveniently hide the option for platforms that have only 3 modifier keys.

commented

I added a test build to #38. Please check it out and let me know if it works as expected, @tflo.

commented

Damn, you did it! It works perfectly! (Even combos work)

Just a minor cosmetic thing for the GUI: The short name of the key is "Cmd", so it would be "CMD" in all uppercase.

"META" is only used by Blizz in the API, on the Mac nobody knows the key under that name. Blizz also uses "CMD" in the Keybinding settings, for example:

Screenshot WoWScrnShot_112422_225528

Btw, also the new options for the color settings are great. Before, I always had difficulties to quickly spot the line in my overloaded tooltips ;)

commented

Just tested it briefly in WotLK Classic, it works great there too!

commented

Good stuff.

This has been merged.

If you would like to add your name to the AUTHORS file, please make a PR.