Translate zhCN.lua strings

Question

Translate zhCN.lua strings

tilkinsc opened this issue 5 years ago · 16 comments

tilkinsc commented 5 years ago

In Locale/zhCN.lua some strings aren't translated fully.

在Locale/zhCN.lua中，某些字符串未完全翻译。

hu71e · Answer 1 · 2019-10-24T04:52:33.000Z

Corrected some incorrect formatting in zhCN.lua, some localized translations have been added and passed the test under version 2.2.5, But iLvl still can not be displayed.

zhCN.lua.txt

tilkinsc · Answer 2 · 2019-10-25T01:38:56.000Z

Hover over a weapon/armor and do /dump GameTooltipTextRight1:GetText()
Also, disable 'could be problem' addons and see if that fixes it.

hu71e · Answer 3 · 2019-10-25T01:52:25.000Z

Empty result

Empty result too, no AddOns loaded but kiwi.

tilkinsc · Answer 4 · 2019-10-25T01:56:16.000Z

Aha. This is expected. Because you are using a bag addon, GetMouseFocus() never pops correctly. So it results in a return.

Because the item couldn't be figured out, nothing became of it.

hu71e · Answer 5 · 2019-10-25T02:01:38.000Z

The second time I just used the kiwi AddOns, I got the same empty result. why？

tilkinsc · Answer 6 · 2019-10-25T02:02:37.000Z

/dump GameTooltipTextRight1 gives results right?

hu71e · Answer 7 · 2019-10-25T02:15:15.000Z

Dump: GameTooltipTextRight1
GameTooltipTextRight1={
[0]=<userdata GameTooltipTextRight1[0]>
}

tilkinsc · Answer 8 · 2019-10-25T02:16:18.000Z

Then you should be able to GameTooltipTextRight1:SetText("ilvl 50") and it would display text.

So yeah... has to be something to do in my function. I would like to confirm that the above code works, also.

I would probably have you print out the values of itemLevel, itemType, focus, name, i_name, i_link, as these are what prevents it from working

tilkinsc · Answer 9 · 2019-10-25T08:37:23.000Z

/run GameTooltipTextRight1:SetText("ilvl 50") (ofc have to hover the tooltip first)

/dump is the equiv of /run return ... where the return pretty prints things out.

tilkinsc · Answer 10 · 2019-10-25T09:33:53.000Z

idk man... works for me

Ahh. I see the problem. It only shows when /kiwiii set ilvl_only_equips true

LOL. Ok... so we got a compatibility issue...

This is what it shows me when I print itemType ... so I guess the itemType system is screwed. So I swapped it with itemClassID, which works as expected. So glad thats fixed.

hu71e · Answer 11 · 2019-10-25T07:13:12.000Z

How to do it? /dump? return the empty result.

tilkinsc · Answer 12 · 2019-10-26T00:43:49.000Z

Can you affirm that the indev branch works?

hu71e · Answer 13 · 2019-10-26T01:26:24.000Z

i see someone else’s tooltip is fine, it maybe my client error.  i will try again when I have enough time. 发自我的iPhone

…

------------------ Original ------------------ From: Cody Tilkins <[email protected]> Date: Sat,Oct 26,2019 8:43 AM To: tilkinsc/KiwiItemInfo <[email protected]> Cc: hu71e <[email protected]>, Comment <[email protected]> Subject: Re: [tilkinsc/KiwiItemInfo] Translate zhCN.lua strings (#15) Can you affirm that the indev branch works? — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

tilkinsc · Answer 14 · 2019-10-26T04:35:51.000Z

Well I did many commits, only one of which actually fixed the problem due to the strings I was comparing against was in chinese instead of english, so I had to convert to itemClassID.

hu71e · Answer 15 · 2019-10-26T07:40:19.000Z

Nice work, iLvl now displays correctly.
In addition, I tested using the 'itemType=="武器"' code to run and also correctly display iLvl.
Thank you!

tilkinsc · Answer 16 · 2019-10-26T17:32:09.000Z

Yes, that would make it run, as that would be like chinese version of Armor or Weapon

Share to