Krowi's Achievement Filter

Krowi's Achievement Filter

738k Downloads

Wrath prepatch compat

Road-block opened this issue ยท 5 comments

commented

C_AreaPoiInfo.GetAreaPOISecondsLeft(event.ID);

local timefunc = C_AreaPoiInfo.GetAreaPOISecondsLeft or C_AreaPoiInfo.GetAreaPOITimeLeft
timefunc(event.ID);

would prevent the error for the missing method

commented

Do you happen to have the error message?

commented

Let me revert my local change

commented

Do you get errors at some point? Cause for me it looks fine atm.

commented

I do get errors on launch without the shim.

You can easily test that the C_AreaPoiInfo.GetAreaPOISecondsLeft method does not exist on the wrath client in-game with /dump type(C_AreaPoiInfo.GetAreaPOISecondsLeft)

They are still using the 8.1.5 method that got removed in 9.x

This is a fresh install of 40.1 on Wrath build 45435, error caught with bugsack.

commented
1x ...ceKrowi_AchievementFilter\Data\EventData.lua:134: attempt to call field 'GetAreaPOISecondsLeft' (a nil value)
[string "@Krowi_AchievementFilter\Data\EventData.lua"]:134: in function `PrimeAreaPoi'
[string "@Krowi_AchievementFilter\Krowi_AchievementFilter-40.1.lua"]:89: in function <...\Krowi_AchievementFilter\Krowi_AchievementFilter.lua:35>

Locals:
(for generator) = <function> defined =[C]:-1
(for state) = <table> {
 5970 = <table> {
 }
 6486 = <table> {
 }
 6490 = <table> {
 }
 6990 = <table> {
 }
 5177 = <table> {
 }
 6487 = <table> {
 }
 5964 = <table> {
 }
 6991 = <table> {
 }
 5178 = <table> {
 }
 6488 = <table> {
 }
 6992 = <table> {
 }
 5969 = <table> {
 }
 5973 = <table> {
 }
 6989 = <table> {
 }
 5175 = <table> {
 }
 5210 = <table> {
 }
 5896 = <table> {
 }
 6489 = <table> {
 }
 5966 = <table> {
 }
 6491 = <table> {
 }
}
(for control) = 5970
_ = 5970
event = <table> {
 TotalDuration = 25200
 MapID = 875
 Name = "Assault on Vol'dun"
 Id = 5970
 Icon = 2065632
 ID = 5970
}
(*temporary) = nil
(*temporary) = 5970
(*temporary) = "attempt to call field 'GetAreaPOISecondsLeft' (a nil value)"
data = <table> {
 TransmogSets = <table> {
 }
 ExportedWorldEvents = <table> {
 }
 Achievements = <table> {
 }
 CategoriesSpecials = <table> {
 }
 ExportedWidgetEvents = <table> {
 }
 SortAchievementIDs = <function> defined @Krowi_AchievementFilter\Data\Data.lua:114
 ExportedPetBattles = <table> {
 }
 SavedData = <table> {
 }
 WidgetEvents = <table> {
 }
 ExportedCalendarEvents = <table> {
 }
 CategoriesExpansions = <table> {
 }
 LoadExcludedAchievements = <function> defined @Krowi_AchievementFilter\Data\Data.lua:78
 GetCurrentZoneAchievements = <function> defined @Krowi_AchievementFilter\Data\Data.lua:94
 CustomObjectives = <table> {
 }
 CategoriesPvP = <table> {
 }
 ExportedUiMaps = <table> {
 }
 CategoriesAchievements = <table> {
 }
 TemporaryObtainable = <table> {
 }
 AddAchievementIfNil = <function> defined @Krowi_AchievementFilter\Data\Data.lua:107
 CategoriesEvents = <table> {
 }
 ExportedTransmogSets = <table> {
 }
 LoadFocusedAchievements = <function> defined @Krowi_AchievementFilter\Data\Data.lua:63
 Maps = <table> {
 }
 RCMenuExtras = <table> {
 }
 FocusedCategory = <table> {
 }
 CalendarEvents = <table> {
 }
 ExportedCategories = <table> {
 }
 ExcludedCategory = <table> {
 }
 ExportedAchievements = <table> {
 }
 LoadBlizzardTabAchievements = <function> defined @Krowi_AchievementFilter\Data\Data.lua:133
 WorldEvents = <table> {
 }
 AchievementIDs = <table> {
 }
 Load = <function> defined @Krowi_AchievementFilter\Data\Data.lua:22
}