Krowi's Achievement Filter

Krowi's Achievement Filter

738k Downloads

Lua error on login

filliph opened this issue Β· 21 comments

commented
1x Interface/AddOns/Krowi_AchievementFilter/API.lua:133: attempt to index local 'category' (a nil value)
[string "@Interface/AddOns/Krowi_AchievementFilter/API.lua"]:133: in function `KrowiAF_SelectCategory'
[string "@Interface/AddOns/Krowi_AchievementFilter/GUI/Misc/AlertFrame/AlertFrame.lua"]:13: in function <...AchievementFilter/GUI/Misc/AlertFrame/AlertFrame.lua:4>

Locals:
category = nil
collapsed = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = "attempt to index local 'category' (a nil value)"
addon = <table> {
 ReplaceVarsWithReloadReq = <function> defined @Interface/AddOns/Krowi_AchievementFilter/Globals.lua:514
 ExcludeAchievement = <function> defined @Interface/AddOns/Krowi_AchievementFilter/Globals.lua:203
 Data = <table> {
 }
 UnitTests = <table> {
 }
 IsShadowlandsRetail = false
 WorldMapButtons = <table> {
 }
 DelayObjects = <table> {
 }
 GUI = <table> {
 }
 DelayFunction = <function> defined @Interface/AddOns/Krowi_AchievementFilter/Globals.lua:650
 Filters = <table> {
 }
 GlobalStrings = <table> {
 }
 Objects = <table> {
 }
 Tutorials = <table> {
 }
 EventData = <table> {
 }
 OnAchievementEarned = <function> defined @Interface/AddOns/Krowi_AchievementFilter/Globals.lua:347
 Options = <table> {
 }
 GetUsableSets = <function> defined @Interface/AddOns/Krowi_AchievementFilter/Globals.lua:564
 Diagnostics = <table> {
 }
 Faction = <table> {
 }
 GetNextAchievement = <function> defined @Interface/AddOns/Krowi_AchievementFilter/Globals.lua:534
 ExtraWrathStrings = <table> {
 }
 Colors = <table> {
 }
 BuildCache = <function> defined @Interface/AddOns/Krowi_AchievementFilter/Globals.lua:313
 Libs = <table> {
 }
 GetCovenantName = <function> defined @Interface/AddOns/Krowi_AchievementFilter/Globals.lua:640
 Util = <table> {
 }
 MetaData = <table> {
 }
 GetFirstAchievementId = <function> defined @Interface/AddOns/Krowi_AchievementFilter/Globals.lua:3
 TrackingAchievements = <table> {
 }
 GetInstanceInfoName = <function> defined @Interface/AddOns/Krowi_AchievementFilter/Globals.lua:612
 GetSecondsSince = <function> defined @Interface/AddOns/Krowi_AchievementFilter/Globals.lua:504
 GetAchievementInfo = <function> defined @Interface/AddOns/Krowi_AchievementFilter/Globals.lua:523
 GetAchievementsInZone = <function> defined @Interface/AddOns/Krowi_AchievementFilter/Globals.lua:20
 IsWrathClassic = false
 GetVariantSetIDs = <function> defined @Interface/AddOns/Krowi_AchievementFilter/Globals.lua:576
 GetLFGDungeonInfo = <function> defined @Interface/AddOns/Krowi_AchievementFilter/Globals.lua:636
 ResetCache = <function> defined @Interface/AddOns/Krowi_AchievementFilter/Globals.lua:343
 TabsOrder = <table> {
 }
 Tabs = <table> {
 }
 IncludeAchievement = <function> defined @Interface/AddOns/Krowi_AchievementFilter/Globals.lua:182
 L = <table> {
 }
 Icon = <table> {
 }
 Credits = <table> {
 }
 GetActiveCovenant = <function> defined @Interface/AddOns/Krowi_AchievementFilter/Globals.lua:16
 HookAchievementFrameOnShow = <function> defined @Interface/AddOns/Krowi_AchievementFilter/Globals.lua:434
 GetAchievementNumbers = <function> defined @Interface/AddOns/Krowi_AchievementFilter/Globals.lua:51
 GetMapName = <function> defined @Interface/AddOns/Krowi_AchievementFilter/Globals.lua:644
 FocusAchievement = <function> defined @Interface/AddOns/Krowi_AchievementFilter/Globals.lua:155
 AddToTrackingAchievementsCategories = <function> defined @Interface/AddOns/Krowi_AchievementFilter/Globals.lua:169
 Event = <table> {
 }
 GetCategoryInfoTitle = <function> defined @Interface/AddOns/Krowi_AchievementFilter/Globals.lua:624
 IsDragonflightRetail = true
 ClearFocusAchievement = <function> defined @Interface/AddOns/Krowi_AchievementFilter/Globals.lua:134
 ChangeAchievementMicroButtonOnClick = <function> defined @Interface/AddOns/Krowi_AchievementFilter/Globals.lua:594
 InGuildView = <function> defined @Interface/AddOns/Krowi_AchievementFilter/Globals.lua:12
 Localization = <table> {
 }
 Plugins = <table> {
 }
 MakeWindowMovable = <function> defined @Interface/AddOns/Krowi_AchievementFilter/Globals.lua:471
 OverwriteFunctions = <function> defined @Interface/AddOns/Krowi_AchievementFilter/Globals.lua:362
}
addonName = "Krowi_AchievementFilter"
SelectCategory = <function> defined @Interface/AddOns/Krowi_AchievementFilter/API.lua:91
commented

It looks like you're clicking one of the event reminders that pop up when you log in. Which event are you clicking on? Can you please try the same thing with only KAF enabled? I'm not able to reproduce it with my setup.

commented

I'm sorry but I can't reproduce it on my end. Have you tried disabling all addons except for KAF and see if you have the same behavior?

commented

Sorry for the delay in getting back to you.

I thought it was happening on login, but as it turns out, I had actually left-clicked the Mogu assault pop-up:

image

I am able to replicate it 100% of the time after a /reload and clicking on this pop-up.

EDIT: The same appears to happen regardless of what pop-up I click.

commented

This might just have been a false alarm, seems like a conflict with GW2_UI which I'm helping test the DF version of.

I'd like to keep this issue open while I ask one of the devs about this, in case they would want you to make any changes to make the two add-ons work together, if that's okay with you? πŸ™‚

commented

Sure, I have a compatibility plugin for ElvUI so other UI mods will be considered too.

commented

@filliph , any update?

Is there something I can do and develop a compatibility? If the latter, please close this one and create a new issue and/or discord suggestion.

commented

Sorry, the GW2 dev has been very busy trying to fix the various taint issues Blizz introduced πŸ˜… I'll poke them to see if it's something that can be given a wee bit more priority πŸ™‚

commented

I'm more than happy to implement something similar like I did for ElvUI. I think it will depend who is looking into it, they or me :)

commented

You could have a wee look, I don't know where the issue would be likely to be, since the pop up does originate from KAF πŸ€”

commented

Another issue by some1 on curse

Hello, open the achievement window and you will see such an error,

After the test, it is found that there is an error with the Edit Mode Expanded plug-in. There is no problem with the 006 version of this plug-in. After the 007 version was updated, the hidden mini menu bar and backpack bar were added. This error occurred. I also contacted the author of Edit Mode Expanded to see what was going on. Foreign players, poor English, software translation, please forgive me.

12x Interface/AddOns/Krowi_AchievementFilter/API.lua:133: attempt to index local 'category' (a nil value)
[string "@Interface/AddOns/Krowi_AchievementFilter/API.lua"]:133: in function `KrowiAF_SelectCategory'
[string "@Interface/AddOns/Krowi_AchievementFilter/GUI/Misc/AlertFrame/AlertFrame.lua"]:13: in function <...AchievementFilter/GUI/Misc/AlertFrame/AlertFrame.lua:4>

Locals:
category = nil
collapsed = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = "attempt to index local 'category' (a nil value)"
addon =

{
ReplaceVarsWithReloadReq = defined @Interface/AddOns/Krowi_AchievementFilter/Globals.lua:520
WorldMapButtons =
{
}
ExcludeAchievement = defined @Interface/AddOns/Krowi_AchievementFilter/Globals.lua:208
Data =
{
}
UnitTests =
{
}
GUI =
{
}
IsShadowlandsRetail = false
Filters =
{
}
DelayObjects =
{
}
GlobalStrings =
{
}
DelayFunction = defined @Interface/AddOns/Krowi_AchievementFilter/Globals.lua:656
Options =
{
}
Objects =
{
}
Tutorials =
{
}
TooltipData =
{
}
EventData =
{
}
OnAchievementEarned = defined @Interface/AddOns/Krowi_AchievementFilter/Globals.lua:351
Diagnostics =
{
}
GetUsableSets = defined @Interface/AddOns/Krowi_AchievementFilter/Globals.lua:570
Faction =
{
}
GetCovenantName = defined @Interface/AddOns/Krowi_AchievementFilter/Globals.lua:646
GetNextAchievement = defined @Interface/AddOns/Krowi_AchievementFilter/Globals.lua:540
ExtraWrathStrings =
{
}
Colors =
{
}
BuildCache = defined @Interface/AddOns/Krowi_AchievementFilter/Globals.lua:317
Libs =
{
}
TrackingAchievements =
{
}
Util =
{
}
MetaData =
{
}
GetFirstAchievementId = defined @Interface/AddOns/Krowi_AchievementFilter/Globals.lua:3
GetInstanceInfoName = defined @Interface/AddOns/Krowi_AchievementFilter/Globals.lua:618
IsWrathClassic = false
GetSecondsSince = defined @Interface/AddOns/Krowi_AchievementFilter/Globals.lua:510
GetAchievementInfo = defined @Interface/AddOns/Krowi_AchievementFilter/Globals.lua:529
GetAchievementsInZone = defined @Interface/AddOns/Krowi_AchievementFilter/Globals.lua:20
MakeWindowStatic = defined @Interface/AddOns/Krowi_AchievementFilter/Globals.lua:466
GetVariantSetIDs = defined @Interface/AddOns/Krowi_AchievementFilter/Globals.lua:582
GetLFGDungeonInfo = defined @Interface/AddOns/Krowi_AchievementFilter/Globals.lua:642
ResetCache = defined @Interface/AddOns/Krowi_AchievementFilter/Globals.lua:347
TabsOrder =
{
}
Tabs =
{
}
IncludeAchievement = defined @Interface/AddOns/Krowi_AchievementFilter/Globals.lua:185
L =
{
}
Icon =
{
}
Credits =
{
}
GetActiveCovenant = defined @Interface/AddOns/Krowi_AchievementFilter/Globals.lua:16
HookAchievementFrameOnShow = defined @Interface/AddOns/Krowi_AchievementFilter/Globals.lua:438
GetAchievementNumbers = defined @Interface/AddOns/Krowi_AchievementFilter/Globals.lua:51
GetMapName = defined @Interface/AddOns/Krowi_AchievementFilter/Globals.lua:650
FocusAchievement = defined @Interface/AddOns/Krowi_AchievementFilter/Globals.lua:159
AddToTrackingAchievementsCategories = defined @Interface/AddOns/Krowi_AchievementFilter/Globals.lua:172
Event =
{
}
GetCategoryInfoTitle = defined @Interface/AddOns/Krowi_AchievementFilter/Globals.lua:630
IsDragonflightRetail = true
ClearFocusAchievement = defined @Interface/AddOns/Krowi_AchievementFilter/Globals.lua:136
ChangeAchievementMicroButtonOnClick = defined @Interface/AddOns/Krowi_AchievementFilter/Globals.lua:600
InGuildView = defined @Interface/AddOns/Krowi_AchievementFilter/Globals.lua:12
Localization =
{
}
Plugins =
{
}
MakeWindowMovable = defined @Interface/AddOns/Krowi_AchievementFilter/Globals.lua:503
OverwriteFunctions = defined @Interface/AddOns/Krowi_AchievementFilter/Globals.lua:366
}
addonNam

commented

Ahh its cause I'm putting custom Events into that Enum. I'll find a different way to do that.

commented

No clue how that could've caused this issue O.o

commented

Its just a guess from this line of code, which is 13 on AlertFrame.lua, second line of the above error:

local category = KrowiAF_SelectCategory(self.Event.Category);

I saw that and remembered that I added a custom Event to Blizzards Enum, which I should have changed earlier.

commented

If thats not the problem (I don't know what triggered the Lua error; I did a bit of testing running both addons and couldn't get it to appear), it could be connected to loading the achievement frame during ADDON_LOADED?

if ( not AchievementFrame ) then AchievementFrame_LoadUI() end

commented

That something you do? KAF relies on the fact that it can load some data first and then for the Blizzard_AchievementUI part to load. If it's the other way around it might cause this issue but not sure about that. Something I can try and check.

commented

Yeah I have to. Its the only way I can guarantee the frame is actually there to be moved/resized. I could delay it to a later event, PLAYER_ENTERING_WORLD or something else if you prefer?

commented

This error is related to Blizzard_AchievementUI loading before KAF is loaded. This is caused by another addon.

commented

I'm going to look if I can fix it on my end cause you addon is not the only one causing it. Gimme a couple of days.

commented

#62 was easy to fix, this one will require a little bit more digging as it's related to the event reminders and sidebuttons not loading.

commented

I'm going to delay AchievementFrame_LoadUI() until a later event, as its causing the Achievements Frame to not load Feats of Strength properly. You may want to check if the same bug happens with your addon.

commented

KAF does not change loading orders, just hooks into it so it should be fine.