Krowi's Achievement Filter

Krowi's Achievement Filter

738k Downloads

Locale is not taken into account by LUA standard functions

Gerokusu opened this issue ยท 4 comments

commented

Problem

When using EventReminders, the formatted date are printed in english no matter what locale you are using.

image

I am using French, on the screenshot above it should be set as "Novembre" (reversed E / R). After investigating the code, it looks like the standard LUA functions do not understand the current locale, as according to the standard documentation they should have this responsibility.

I checked with print(GetLocale()) just before AlertFrameMixin.lua:26, the result is frFR for me, which is correct.

Proposition

A quick win would be to get the date month index, use an array of months in the translation files, and hard print this value directly into the string, ignoring the %B format. It is quite dirty though and ignores a normally standard way of operating.

commented

I assume this is the same for both Wrath Classic and Dragonflight?

commented

I did not test it on Classic, only on Dragonflight, but I assume it should have the same behaviour.

commented

@Gerokusu just wondering, is your pc in French or English?

commented

Everything in my PC, including language, locale, keyboard layout and WoW, is French. I do have an English language pack installed but it is disabled, I don't think it should interfere.