KuiNameplates

KuiNameplates

11M Downloads

npc title text shows levels on languages other than en-us

kesava-wow opened this issue ยท 10 comments

commented
commented

I wonder: Would completely turning off NPC titles (not just the level part) lead to their names coming down a row (where the title used to take space) or would this just leave an empty space?

commented

It would adjust to be in the centre of the frame, yes.

commented

Is there a specific reason why names are adjusted to the center of the frame instead of the bottom? Elvui does place them at the bottom, which still seems far enough (as in nearly too far) above the head a player/NPC.

commented

Just because I want the frame to be in the center of the clickable area (which addons can't move), really.

commented

Thanks for the info.

commented

Needs to be tested on other languages. I suspect the translation of "level" has the potential to be different depending on what follows.

https://www.townlong-yak.com/framexml/live/GlobalStrings.lua contains the en-us translations, including LEVEL, TOOLTIP_UNIT_LEVEL.

commented

Works well with a German client. ;)

commented

this commit tested working on German, French, Russian, Korean, Chinese, English

commented

Scratch that, doesn't work with elites (somehow I didn't actually test it in dalaran.)

commented

Extra overhead this time but I'm not really sure how else to deal with it. Tooltip parsing is annoying.