Purge shows things I can't purge/doesn't show things I can purge
Rendalll opened this issue ยท 6 comments
Hey, I wanted to show enemy buff that I can purge so I activate show auras and show purge but nothing is showing on the plate any idea why ?
thanks for the work on the addon btw
Was there a particular buff you know you can purge which wasn't being shown?
Purge relies on what the game tells me. So as long as both "show auras" and "show purge" are enabled, whatever the game says you can purge should show up in the purge frame.
None of the spell i can purge shown, as an exemple the sham wolf form doesn't show up, I've also compare my setting with a friend that also use this addons but I still don't know were the issue is comming from :/
Don't believe this is a KNP problem per se. Perhaps something else is causing the issue. Best is to try and disable all addons and test only KNP. I see all purgeable buffs on the nameplates with no issue, including your example.
@kesava-wow the issue with purging is that the addon is interpreting the isStealable
return from UnitAura
as can_purge
(
Things like enrages are not handled by this addon at all for classes that can remove enrages. Checking the debuffType
from UnitAura
would probably be a more robust solution here. An important note: due to an ages-old Blizz bug, the "enrage" dispel type is returned as emptystring, not "Enrage". Auras without a dispel type return debuffType
as nil.
Doing this probably requires creating a map between classes and their valid dispel types (or their dispel spells, from which you could check if the needed dispelling-spell is learned or not)
Thanks. I should probably explore using a map, or maybe there's a library for it. I grew wary of hardcoding lists like that the last time I did it.
Nevermind, your usage here actually does seem to be correct. I guess the usage of that return variable has changed (since a few, but I wouldn't even say many nor most, enrages seem to show up as purgables for me as a hunter), but as you pointed out, the game seems to often report this wrong.