Keystone links are not handled properly
xeropresence opened this issue · 2 comments
This is the cause for
Looks like
https://github.com/Jaliborc/LibItemCache-2.0/blob/master/LibItemCache-2.0.lua#L267
Fails to process keystone items as
GetItemInfo will return nil for a item.link such as
link="|cffa335ee|Hkeystone:158923:248:14:10:5:13:16|h[Keystone: Waycrest Manor (14)]|h|r",
Some useful info perhaps from the raider.io addon, patterns for the m+ keystone item.
local KEYSTONE_PATTERNS = {
"keystone:%d+:(.-):(.-):(.-):(.-):(.-)",
"item:158923:.-:.-:.-:.-:.-:.-:.-:.-:.-:.-:.-:.-:(.-):(.-):(.-):(.-):(.-):(.-)"
}
I have deployed this change locally, and while it will let you search for "mythic","keystone" you cannot search for the dungeon name or level.
tried a dirty fix of partial = partial:gsub('keystone:', 'item:') in the function Lib:RestoreLinkData(partial) and it seems to work. probably not the best way to do this, but at least it exposes the problem, GetItemInfo* has been broken in 8.3 for complete keystone links
