Warrior LibPlayerSpells is barebones
dafzor opened this issue ยท 6 comments
Not going to open one per spell on this one since they're practically all missing from LibPlayerSpell so here's a more complete list:
Interrupts:
- 6554, Pummel
- 102060, Disrupting Shout (removed in 6.0)
- 57755, Heroic Throw with glyph of Gag Order (debuff: "Silenced - Gag Order")
Buffs:
- 6673, Battle Shout, RAID AP
- 469, Commanding Shout, RAID HP
- 13046, Enrage (probably can't be displayed in an ability but needed for other stuff to display)
- 34428, Victory Rush
- 103840, Impending Victory (talent, should also lightup on victory rush proc)
- 3411, Intervene (applied on target)
- 114029, Safeguard (talent, applied on target)
- 7384, Overpower, Shine on Sudden Execute buff (removed in 6.0)
- 78, Heroic Strike and 845, Cleave should show Stack when under the effect of Glyph of Incite
Debuffs:
- 20243, Devastate (weakened armor)
- 6343, Thunder Clap (weakened blows)
- 5246, Intimidating Shout (fear)
- 1715, Hamstring (slow)
- 12323, Piercing howl (slow, removed in 6.0)
- 107570, Storm Bolt (stun)
- 46968, Shockwave (stun)
- 107566, Staggering Shout (root, removed in 6.0)
- 676, Disarm (disarm, removed in 6.0)
- 64382, Shattering Throw (temporary armor debuff, removed in 6.0)
- 355, Taunt (taunt)
- 12294, Mortal Strike (healing debuff)
- 86346, Colossus Smash (personal armor ignore)
DPS Cooldowns:
- 1719, Recklessness
- 12292, Bloodbath (talent)
- 46924, Bladestorm (talent)
- 107574, Avatar (talent)
- 12328, Sweeping Strikes
Defensive CDS:
- 18499, berserker rage (fear breaker and causes enrage)
- 871, Shield Wall
- 12975, Last Stand
- 55694, enrage regeneration (talent, should shine on enrage aura at least until 6.0 is out)
- 1160, Demoralizing shout (self buff and mob debuff)
- 23920, Spell Reflection
- 114028, Mass Spell Reflection
Raid Cds:
- 114030, Vigilance (talent, tank cd)
- 97462, Rallying Cry
- 114192, Mocking Banner
- 114203, Demoralizing Banner (removed in 6.0)
- 114207, Skull Banner (removed in 6.0)
Active mitigation:
- 2565, Shield Block (the buff doesn't seem to connect to the button spell)
- 112948, Shield Barrier (could also shine when at 60 rage)
This should mostly cover Arms and Protection, Fury specific spells are still missing.
You can just use this for the power:
ShowPower {
112048, -- Shield Barrier
"RAGE",
60,
"flash"
}
There are some docs there : https://github.com/Adirelle/AdiButtonAuras/tree/master/doc
I see, would it be possible o push an alpha to the addon sites please? Regardless I've updated to the github version and will be mindful of commit log in the future.
Warrior is mostly fixed for Prot and Arms already. You just don't have the current github version.
Some people could surely find it annoying, which makes me wonder if there's a way to make a Configure off by default.
Tested it today, Incite proc was still missing, adding it with:
line 99:
122016, -- Glyph of Incite
line 133:
[122016] = { 78, 845, }, -- Incite, Demoralizing Shout => Free Heroic Strike, Cleave
Seems to work, also been looking into the monk module to see how to add an hint for shield barrier above 60 and this seems to work:
return {
ImportPlayerSpells { "WARRIOR" },
Configure {
"Shield Barrier",
addon.L["Show hint when rage above 60."],
112048, -- Shield Barrier
"player",
{ "UNIT_POWER" },
function(_, model)
if UnitPower("player") >= 60 then
model.hint = true
end
end,
},
}