LibPlayerSpells-1.0

52.9k Downloads

Snares, sprints and DR spells ?

Adirelle opened this issue ยท 4 comments

commented

Should I add Snares and sprints (e.g. temporary moving speed alterations) ? I am also considering dropping DRData support and dispatching all its data into LPS.

I think it would ease maintaining it by gathering all the data in one library, but yet keeping a list per class.

Any thought ?

commented

Diminishing returns categories that can be tracked by using UNIT_AURA are now part of LPS under the special category CROWD_CTRL. AdiButtonAuras now pulls its DR data from LPS and support for DRData-1.0 has been dropped.

Knockbacks (KNOCKBACK) and Silences (INTERRUPT) are ordinary flags. Snares are also an ordinary flag (SNARE). Knockbacks and snares are either not yet or just partially tagged.

commented

This is actually fine. It eased the integration into oUF_Adirelle so I could drop the dependency to DRData-1.0.

commented

I think having a single library for spell information makes sense. If I was a new author and looking for spell information I'd check LPS first and then be confused as to why I need another library for diminishing return information.

commented

Moving the spells from DRData to LPS but leaving the added value (diminishing returns reset times) in DRData makes sense in my opinion.

I find moving speed alterations also interesting.