LibProcessable

Addons
14.8k Downloads

Flaw in :IsDisenchantable logic when using garrison building and items below level 21

Blazeflack opened this issue ยท 2 comments

commented

By default GetSkillRequired returns "1" when quality is 2 and level is below 21.

When using the garrison enchanting building, this leads to :IsDisenhantable to return true for those items, when in fact low level items like that cannot be disenchanted at the garrison building.

commented

Should have been resolved by now, most likely from one of these commits:
ffd2dee
c36316e

Feel free to let me know if it's still not working correctly.

commented

I modified the enchant building return to read

return skillRequired == 1 and not (quality == 2 and level < 21), skillRequired

Which solved it. I don't know if you have a better way to do it.