TWW - Handle new mount types for expanded skyriding
mbattersby opened this issue · 6 comments
Yeah this is more complicated than it looked. There are 5 new categories of mount type ID, these are my best guesses so far at what they are. I don't know what capabilities they have.
424 -- Flying (and eventually Dragonriding) Drakes and others
426 -- Copies of the Dragonriding mounts for the Azeroth flying competition
428 -- Flying (and eventually Dragonriding) Proto-drakes and others
429 -- Flying (and eventually Dragonriding) Rocs and Pterrordax
430 -- Literally only "Temp" which I guess is Blizzard testing something
I have no idea why 424/248/429 are separate or if they should be treated differently. I think 426 and for now 430 can probably be excluded as irrelevant to LiteMount usage, but I can't say for sure.
Originally posted by @mbattersby in #157 (comment)
Type (ID) filtering is affected by this in an annoying way in that you can no longer filter out those newly classified mounts at all, might wanna do a quick fix for that too
edit: I see in SpellInfo.lua that a quick fix is out of the question, gonna take some refactoring for that. I think for now putting all those mounts under just Flying should be the right way to go, since they aren't Dragonriding mounts yet in retail anyway (I think the type id changes are mostly preparatory work on Blizzard's side)
I have no idea what you're talking about, they are all part of Flying in the filtering and working just fine.
OK I'm an idiot, I forgot to put out a new release with the fixes. Thanks for the prompting.
doh! I hadn't actually looked at the repo itself to see you had made those changes already