Little Buster

Little Buster

Addons
132k Downloads

ItemIDs dont contain enough information - Tooltips show wrong stats

aLanaMaunz opened this issue · 2 comments

commented

LittleBuster/src/littleBuster.tl

Lines 290 to 294 in 57ba24c

if (tooltipState.itemID == itemID and tooltipState.timesSeen > 1) then
tooltipState.timesSeen = tooltipState.timesSeen + 1;
injectModifiedLines(tooltip, tooltipState.modifiedLines);
return;
end

Hello, the ID you extract contains only the base information about an item. All rings listed here have the same item ID: https://tbc.wowhead.com/item=25056/almandine-ring
This will show tooltips with wrong stats - just look in the auctionhouse for the ring and click multiple different rings.

You should improve your ItemID calculation, or maybe also use the ItemName to check for necessary tooltipupdates. A dirty fix is just removing the lines - it will affect the performance because the whole tooltip is updated every second without this.

commented

Oh hey, that's right, I remember noting this myself. Thanks for filing an issue, because it completely slipped my mind! I'm pretty sure I even know how to make a "proper" fix.

  • ❤️1
commented

Okay, this was actually even simpler than I expected it to be.

Closed by 555f492.

It'll go out in the next release. Thanks again!

  • 🎉1