Court of Stars buff helper bugs
MysticalOS opened this issue ยท 9 comments
- Cooking level shouldn't be 800.
- All the profession icons are wrong with 10.x so they aren't alerting. Grab all the updated texture Ids from (https://github.com/DeadlyBossMods/DBM-Dungeons/blob/master/DBM-Party-Legion/CourtofStars/CoSTrash.lua#L274-L423)
- None of them actually require level 100 either. from my observation about 50 seems accurate. could even be lower but I just know when my engineering and blacksmithing were at DF 50, they were usable. checking for 100 again alienates available players cause getting to 100 is MUCH harder since it can only be done via work orders over period of time for some professions.
I checked with even low level alts. the DF textures are used/returned by api regardless of profession tier. IE it can be "bfa mining" and still return the new mining icon.
PS, you don't have to do anything to be compat with DBM, I did legwork by completely using the BW sync protocol so it's literally seamless. Special thanks to funky for letting me do so. This helps improve both mods.
Do you think the skill requirements might be different in different difficulties? At least on regular Mythic I was able to go learn Tailoring and even at 1 skill it was enough:
And actually even 1 skill in Classic Skinning allows me to activate the Skinning one:
All the profession icons are wrong with 10.x so they aren't alerting. Grab all the updated texture Ids from (https://github.com/DeadlyBossMods/DBM-Dungeons/blob/master/DBM-Party-Legion/CourtofStars/CoSTrash.lua#L274-L423)
You're having issues with the profession icons alerting? I haven't experienced this. Nevermind I see the issue with that now.
I've had numerous users in my group complain they didn't get alert I had an available profession. when I did code review it was scanning for old profession icon but I was sending the new one in comms. Basically dragonflight revamped profession artwork, so it's got new texture ids now
As for required skill level. Yeah it could be 1. I only confirmed definitively 50 was enough (and 100 was def not required).
As for required skill level. Yeah it could be 1. I only confirmed definitively 50 was enough (and 100 was def not required).
I confirmed in M+ that 25 skill is enough. Don't have any max-level chars with just 1 skill to test that though but based on M0 being 1 skill I think that's most likely.
Updated profession IDs in f90b662, also found that Cooking is a valid profession for Umbral Bloom, that was missing before.
--45278 Haste Buff Court of Stars (cooking/herbalism?)
--45168 Cooking Interaction buff
--45332 Engineering interaction to break robots
--Distractions (to separate boss)
--45473 Warrior Distraction Court of Stars
Here are some gossip IDs i collected. I stopped collecting though cause I got lazy and went "well, if it isn't the boat, or disguise, or spy interactions. then it's an item interaction"
Yeah I gave up on switching to using gossip IDs when the poison for the first boss had a different ID on my Rogue compared to my alchemist. For the buffs it's probably safe enough to just choose the first (only) option. Just kept the ones I collected in case it's ever needed in the future.
Anyway, thanks for the report. Hopefully everything is syncing well now between DBM and LW.
yeah syncing already spot on, and since you synced found ID it was already correct ID, this report was more to fix little wigs, which i talked to several users using LW in my group that were like "yeah professions haven't worked all expansion"
but i'm sure you well know now, users reporting that HERE isn't always great. people used LW for months without saying "btw it's broken". I know the feelings :D