Ability warnings do not have hostility check
ljosberinn opened this issue · 4 comments
Describe the problem
When any kind of MC-like ability controls NPCs in dungeons with default-noteworthy abilities that LittleWigs will pop a notification for, these still come up even if the controlled NPC is currently friendly which shouldn't happen.
What steps will reproduce the problem?
- Mind-control or Control Undead any NPC in keys
- Have them cast a notable ability, like Soul Blade in BRH
- Note how the announcement comes up despite the mob being friendly atm
Consider attaching a screenshot below to help describe your issue (Attach directly, do not link to other websites)
What version of LittleWigs are you using? (Stating 'latest' is not useful)
latest. doesnt matter, its been a thing for long but only recently realized why
Do you have an error log of what happened?
no error thrown
Any additional information? (example: WoW language if not English)
considering youre operating on CLEU, sourceFlags (?) need to be checked
We don't just slap hostile checks on everything, only the things that can actually be mind controlled that can cast the abilities we are warning for.
If there are multiple mobs you are mind controlling, name them here please. Even better if you have videos just link them here.
https://www.twitch.tv/videos/2002925420?t=14h54m23s here for example, Soul Blade via https://www.wowhead.com/npc=98366/ghostly-retainer
there's a couple humanoids in atal too but can't recall a specific case right now
