Resets clearing if cross realms
chancedj opened this issue ยท 12 comments
If you have characters on multiple realms, GetServerTime() returns the wrong time and could result in clearning out the characters too early. Work on a fix to store the offset between ServerTime and Local Time so that the clearing happens properly.
https://wow.gamepedia.com/API_GetQuestResetTime
problem may actually be with this function returning the "wrong" value.
proposed fix: on char rebuild test return value. if > 24 * 60 * 60, then exit and reattempt later.
Might have this still occuring. Running latest build (Latest commit bc2de3c 12 hours ago), my priest had cleared 1/11 Karazhan, yet the addon shows no lockout until i log him. It was same for my monk few mins before that (don't have screenshots for monk).
I have chars on 2 realms: Quel'Thalas (EU) (which is a merged realm) and Aerie Peak (EU)
after logging on priest
This one has to do with me changing the events around due to the instant reset complete. I need to find the event fired when you're saved to an instance and it will correct this. Before, player entering world always fired when going in and out of an instance - so when you leave the instance and log out it was resetting the addon and adding the karazan kills.
I was using the player entering world as a blanket way to "correct" the addon, so now i just need to get the correct ones added to fire. hopefully that makes sense.
Why wouldn't the addon just write to the database at the time of a lock/save (boss/dungeon/quest etc) and then only access it from cache until expiry? (or atleast hardcode a reset/resync with server every week on restet day, in case it gets erroneous expiry times, like 43 days reset)
closed with latest commit. testing happening in issue #67
ok. latest checkin should now rebuild for when a raid or instance boss kill ends successfully.
yes. thats the plan :). that's what i meant by that. before i was using the player login event as a blanket fix because i didn't subscribe to the events. i just need to find the event that's fired when you're saved to an instance and that should be corrected.
This issue still happens. Latest 1.6 build. Just logged out from warlock Viesse (who just killed 1st boss in Karazhan), it was shown on LockedOut when I was on Viesse. Now switching chars to Diessen (on same realm - Aerie Peak EU) shows no save for Viesse anymore. Also Jaesse (on same realm) has killed 1st boss in Karazhan earlier today, is missing in the photo.
i'll reopen. i'm still not seeing the issue happen but will keep it open for a while to see if there's a pattern. i'm just about ready to release and i think we're good without this being fixed as it's really hard to track down atm.
Might have to enable debugging and see if i can get a printout from you with it enabled.
Sure, enable debugging for beta.
Would it be complicated to add a toggle for debugging?
nope. shouldn't be difficult. what i'll have to do is probably stuff it all into an array then spit it out later. there are times as the ui is getting it's stuff together that i can't print to the chat window. so i would stuff to the variable then loop when the ui is ready and send it to the chat window.
It's a really odd bug you're seeing. hopefully with the debug statements we can get to the bottom of it.
As part of the fix for #70 - i'm going to rewrite this code and hope it corrects the issue with 1.7.0.