LS: Glass

LS: Glass

57.5k Downloads

Second chat window tab wont fade upon login

Closed this issue · 8 comments

commented

Hi, Everything about the addon works super well except for one thing i've noticed.

Context, I have the main chat window (General, combat log, Etc_ and then have a seperate chat window for loot only.
When I login, the chat tab for the Loot window will not fade out and will remain on screen forever, until I click the tab upon which it will fade away fully.

Any way this could be fixed to fade fully on login?

Thanks!

commented

Hi, the issue is fixed in the version for TWW. Half the addon code was rewritten which also inadvertently fixed the issue along the way 😅

fading_on_login

Just wait for a week and it'll be fine.

commented

Heya LS,

Sorry to bring this up again!
Overall the new version is great and works really well, so thank you for your hard work on that.

I've found that the issue with the second chat window tab not fading can sometimes occur when hearthstoning, using the vulpera back to camp ability or using portals.

It doesn't seem to happen every time, but I often notice the tab has remained after doing one of the above which involve a loading screen.

Its not a huge deal, just something I noticed.

commented

A few days ago I noticed an odd behaviour when the dock (tabs + buttons) wouldn't fade as expected, but it's fixed in this commit. So it prob will be fixed in today's update... Probably 🤔

commented

Lovely thank you! I'll update when available and if you don't hear anything from me then it's probably fixed!

commented

Unfortunately seems like it still occurs sometimes when portaling and other loading screen activities

commented

Hmm... I'll look into it, I know how to fix it at this point, but not now, I bit busy with real life stuff 😵

commented

Thank you LS, I appreciate it!

If it helps, I have found a guaranteed way to trigger the issue.

I booted the game up fresh and logged into my character.
Without touching the chat frame or anything, I used the Vulpera racial "return to camp" which ported me away.

After the loading screen, the second tab was present but not fully faded.

Hopefully this provides you with a repeatable method :)

commented

Yeah, I realised what's going on after you mentioned loading screens earlier. What's happening is that, I can't truly control dock fading on my end due to how it's implemented on blizz end, like, if I try to override that behaviour I'll literally break the whole UI when you're in combat 😵

So I let Blizz code do its thing, for instance, it fades out the tabs after a certain period of time, but it only fades them out to like 0.25 alpha, and on my end I do the rest and fade them out completely. But what happens when you go through a loading screen is that Blizz code resets stuff, but my code still thinks that it's fully faded out.

To fix that I'll just need to reset the state on my end as well, it's not hard, I'm just busy atm.