Update to 1.14.4

Question

Update to 1.14.4

viking11 opened this issue a year ago · 23 comments

viking11 commented a year ago

Blizz dropped a 1.14.4 update out of nowhere and LUF seems to have stopped working, it doesn't even show up in in-game addon settings. Would it be possible to fix this before hardcore release?

caboyd · Answer 1 · 2023-08-26T00:41:19.000Z

Ok, wierd. Did you check just the target? I think it was target of target of target. :D But whatever. If it works, it works. Probably just needs updated libs and then its good to go.

Same issue here with the flickering on ToT, it seems to happen on resource, and only if you have the background alpha set to low, if you max it out, the flickering stops.

I don't play with ToT power bars on but it does flicker when i turn it on. You can stop the flicker by editing \Interface\AddOns\LunaUnitFrames\libs\oUF\elements\power.lua and comment out line 132. I don't know if that breaks anything but it seems ok.

if(atlas) then
	element:SetStatusBarAtlas(atlas)
	element:SetStatusBarColor(1, 1, 1)
else
	--element:SetStatusBarTexture(element.texture)

	if(b) then
		element:SetStatusBarColor(r, g, b)
	end
end

pquerner · Answer 2 · 2023-08-24T15:57:28.000Z

The original author stopped playing the game, and this is a quick fix on the classic branch.
Not sure if anything else stopped working, but atleast you get open the options menu and change some stuff. I havent tested every option available, for obvious reasons.

Step 1) Remove the folders belonging to Ace3 from the libs folder
Step 2) Copy the Ace folders from another Addon, that uses the same Ace3 library (same naming), such as Questie
Step 3) Go in file oUF_SimpleAuroas.lua and change the following line

if(button.count) then button.count.SetText(count > 1 and count) end

to

if(button.count) then button.count.SetText(tostring(count > 1 and count)) end

pquerner · Answer 3 · 2023-08-24T16:03:03.000Z

Ok after posting that and playing for more than 2 seconds on the current PTR, I found more issues. This required looking more into the sourcecode but I probably won't provide a solution for that.

caboyd · Answer 4 · 2023-08-24T23:30:00.000Z

I did your steps but changed the line to

if(button.count and count > 1) then button.count.SetText(count) end

No errors yet.

Edit: above change errors with the preview auras toggle. Below change just updates the text always with no error

button.count:SetText((count > 1 and count) or "")

pquerner · Answer 5 · 2023-08-24T23:32:08.000Z

Attack a mob in the nightelf starting area and see what happens to the mobs "energy" bar. (For me it flickered heavily, alhough no mob used mana or rage or anything there)

Also (not sure if that was always like that) the frames seems too much glued together. It wasnt possible for me to select the player unitframe without moving the party frames or target frame for instance. Probably that shouldnt be the case.
(But is probably fixable by disabling the glued frame in the options menu, menu your unitframe to whereever it needs to be, and enable the other unitframes again)

caboyd · Answer 6 · 2023-08-24T23:39:00.000Z

I dont see any issues with flickering. You can change what each frame is anchored to in the general settings of each frame

pquerner · Answer 7 · 2023-08-24T23:40:42.000Z

Ok, wierd. Did you check just the target? I think it was target of target of target. :D
But whatever. If it works, it works. Probably just needs updated libs and then its good to go.

lvangh · Answer 8 · 2023-08-25T03:59:02.000Z

I'd give an arm and a leg to have a working version. I've been using Avi's Luna since pserver days and now I'm looking into other options and I see how limited they are. Aviana should have gotten more credit for building on the foundation of SuF/OuF - the features added are miles above those and other UFs.

HGaleIOPP · Answer 9 · 2023-08-25T04:34:29.000Z

Ok, wierd. Did you check just the target? I think it was target of target of target. :D But whatever. If it works, it works. Probably just needs updated libs and then its good to go.

Same issue here with the flickering on ToT, it seems to happen on resource, and only if you have the background alpha set to low, if you max it out, the flickering stops.

I'm also having an issue where the frames seem to update very slowly, quite often when I swap target it doesn't update to my current target until they lose HP, or use some resource, and until then they're the target I was previously targetting.

Outside of that though, it's still working absolutely fine, but will need to look for an alternative at some point soon if it's not easily fixable.

Kerzot · Answer 10 · 2023-08-25T08:47:59.000Z

The Target Buffs/Debuffs no longer time down, they are just on or off. Although If i target myself i can see mine time down...

Zyin055 · Answer 11 · 2023-08-25T14:20:08.000Z

Also getting the problems mentioned above after reinstalling Classic Era to play hardcore. It's a shame Luna isn't in development anymore, I've been using it for the past 4 years and it was a great addon.
Shadowed Unit Frames is very similar to Luna so I made the switch to that.

pquerner · Answer 12 · 2023-08-25T11:23:55.000Z

The Target Buffs/Debuffs no longer time down, they are just on or off. Although If i target myself i can see mine time down...

That was a limitation of vanilla iirc. You can get around that by installing another addon. If it plays nice with Luna I dont know.
The AddOn is called "ClassicAuraDurations".

Kerzot · Answer 13 · 2023-08-25T15:26:01.000Z

Interesting, the debuffs used to tick down on target frame before the patch, and i didn't have any other add-on that i know of that would have done that. I assumed it was built into luna. Could it have been neatplates that was helping? I thought neatplates was just for the nameplates.

Also, i see Questie and Luna share a few more libs than just ACE, any need to replace LibSharedMedia-3.0, or CallbackHandler-1.0 too ?

And i just get the floating question mark for party picture, for members that are not in that load range, instead of the default picture.

I actually have had less problems with just running the WOTLK version for Vanilla...

pquerner · Answer 14 · 2023-08-26T09:25:46.000Z

Also, i see Questie and Luna share a few more libs than just ACE, any need to replace LibSharedMedia-3.0, or CallbackHandler-1.0 too ?

I don't see the need to. It didnt yield any lua errors.

And i just get the floating question mark for party picture, for members that are not in that load range, instead of the default picture.

Haven't had this, but probably classic limitation? No idea.

I actually have had less problems with just running the WOTLK version for Vanilla...

Good idea, but probably has some other side effects not yet visible. Totem bar comes to mind?
But could probably work.

You can stop the flicker by editing [...]
Nice. My own resource bar flickered aswell. The alpha setting helped.

All my comments here was with a fresh install.

lvangh · Answer 15 · 2023-08-27T22:28:41.000Z

Since we're piecing together errors - any clues on this one? I tried to code block this but it didn't work.

Message: ...UF_RaidStatusIndicators/oUF_RaidStatusIndicators.lua:232: bad argument #1 to 'SetText' (Usage: self:SetText([text]))
Time: Sun Aug 27 17:23:26 2023
Count: 1
Stack: ...UF_RaidStatusIndicators/oUF_RaidStatusIndicators.lua:232: bad argument #1 to 'SetText' (Usage: self:SetText([text]))
[string "@Interface/AddOns/LunaUnitFrames/libs/oUF/ouf.lua"]:201: in function `UpdateAllElements'
[string "@Interface/AddOns/LunaUnitFrames/libs/oUF/ouf.lua"]:55: in function <Interface/AddOns/LunaUnitFrames/libs/oUF/ouf.lua:40>
[string "@Interface/AddOns/LunaUnitFrames/libs/oUF/ouf.lua"]:78: in function <Interface/AddOns/LunaUnitFrames/libs/oUF/ouf.lua:71>
[string "=[C]"]: ?
[string "=[C]"]: in function `SetAttribute'
[string "@Interface/FrameXML/SecureGroupHeaders.lua"]:210: in function <Interface/FrameXML/SecureGroupHeaders.lua:130>
[string "@Interface/FrameXML/SecureGroupHeaders.lua"]:495: in function `SecureGroupHeader_Update'
[string "@Interface/FrameXML/SecureGroupHeaders.lua"]:62: in function <Interface/FrameXML/SecureGroupHeaders.lua:60>

Locals: self = LUFHeaderraid1UnitButton2 {
 SimpleAuras = Frame {
 }
 Highlight = Texture {
 }
 UNIT_MAXPOWER = <table> {
 }
 ResurrectIndicator = Texture {
 }
 modules = <table> {
 }
 unitEvents = <table> {
 }
 UNIT_MAXHEALTH = <table> {
 }
 bg = Texture {
 }
 UNIT_POWER_FREQUENT = <table> {
 }
 UNIT_POWER_BAR_SHOW = <function> defined @Interface/AddOns/LunaUnitFrames/libs/oUF/elements/power.lua:203
 SetPowerUpdateMethod = <function> defined @Interface/AddOns/LunaUnitFrames/libs/oUF/elements/power.lua:292
 style = "LunaUnitFrames"
 PvPIndicator = Texture {
 }
 RAID_TARGET_UPDATE = <function> defined @Interface/AddOns/LunaUnitFrames/libs/oUF/elements/raidtargetindicator.lua:62
 UNIT_CONNECTION = <table> {
 }
 indicators = <table> {
 }
 PLAYER_LOGIN = <table> {
 }
 unit = "raid3"
 toplevel = Frame {
 }
 UNIT_AURA = <table> {
 }
 SetPowerUpdateSpeed = <function> defined @Interface/AddOns/LunaUnitFrames/libs/oUF/elements/power.lua:288
 UPDATE_MOUSEOVER_UNIT = <table> {
 }
 tags = <table> {
 }
 BetterHealthPrediction = <table> {
 }
 __tags = <table> {
 }
 PLAYER_ENTERING_WORLD = <function> defined @Interface/AddOns/LunaUnitFrames/libs/oUF/ouf.lua:184
 INCOMING_RESURRECT_CHANGED = <function> defined @Interface/AddOns/LunaUnitFrames/libs/oUF/elements/resurrectindicator.lua:60
 id = "3"
 UnwrapScript = <function> defined @Interface/FrameXML/SecureHandlers.lua:788
 __customargs = <table> {
 }
 UNIT_PET = <table> {
 }
 UNIT_HEALTH_FREQUENT = <table> {
 }
 BorderHighlight = <table> {
 }
 __mousetags = <table> {
 }
 UNIT_SPELLCAST_SENT = <function> defined @Interface/AddOns/LunaUnitFrames/libs/oUF/elements/castbar.lua:91
 PARTY_MEMBER_ENABLE = <function> defined @Interface/AddOns/LunaUnitFrames/libs/oUF/elements/health.lua:120
 ClassIndicator = Texture {
 }
 Power = StatusBar {
 }
 RaidRoleIndicator = Texture {
 }
 count = FontString {
 }
 cd = LUFHeaderraid1UnitButton2__ownerRaidStatusCD {
 }
 UNIT_THREAT_SITUATION_UPDATE = <table> {
 }
 READY_CHECK = <function> defined @Interface/AddOns/LunaUnitFrames/libs/oUF/elements/readycheckindicator.lua:108
 SetHealthUpdateMethod = <function> defined @Interface/AddOns/LunaUnitFrames/libs/oUF/elements/health.lua:245
 RaidStatusIndicators = <table> {
 }
 StatusPortrait = <table> {
 }
 SetHealthUpdateSpeed = <function> defined @Interface/AddOns/LunaUnitFrames/libs/oUF/elements/health.lua:241
 Execute = <function> defined @Interface/FrameXML/SecureHandlers.lua:777
 MasterLooterIndicator = Texture {
 }
 RaidTargetIndicator = Texture {
 }
 UNIT_COMBAT = <table> {
 }
 GROUP_ROSTER_UPDATE = <table> {
 }
 LEARNED_SPELL_IN_TAB = <table> {
 }
 SetFrameRef = <function> defined @Interface/FrameXML/SecureHandlers.lua:793
 PARTY_LEADER_CHANGED = <function> defined @Interface/AddOns/LunaUnitFrames/libs/oUF/elements/leaderindicator.lua:63
 Range = <table> {
 }
 READY_CHECK_CONFIRM = <function> defined @Interface/AddOns/LunaUnitFrames/libs/oUF/elements/readycheckindicator.lua:108

`Message: ...UF_RaidStatusIndicators/oUF_RaidStatusIndicators.lua:232: bad argument #1 to 'SetText' (Usage: self:SetText([text]))
Time: Sun Aug 27 17:27:00 2023
Count: 19
Stack: ...UF_RaidStatusIndicators/oUF_RaidStatusIndicators.lua:232: bad argument #1 to 'SetText' (Usage: self:SetText([text]))

Locals: `

caboyd · Answer 16 · 2023-08-29T02:05:26.000Z

Since we're piecing together errors - any clues on this one? I tried to code block this but it didn't work.

try throwing a or "" in line 232

indicator.count:SetText((count > 1 and count) or "")

lvangh · Answer 17 · 2023-08-29T03:58:30.000Z

Since we're piecing together errors - any clues on this one? I tried to code block this but it didn't work.

try throwing a or "" in line 232
indicator.count:SetText((count > 1 and count) or "")

Any clues or what the heck would have changed in the API that would require a check for "or blank"?

caboyd · Answer 18 · 2023-08-29T08:45:12.000Z

I don't really know lua but I assume the original writer was using some shorthand that didn't use to cause an error. Basically if count is not greater than 1 it will call the function with false/nil when it expects a string. I think Blizzard changed it on retail last year and now it got pushed to the Era client.

Kerzot · Answer 19 · 2023-09-05T06:28:39.000Z

I hear they changed a bunch of spell ids, wonder if someone will update LibClassicCasterino to drop into the luna libs folder.

Kerzot · Answer 20 · 2023-09-05T04:38:24.000Z

The Wotlk version works better, but does not have the target debuff aura durations libs support the classic version had. Which don't work anymore anyway i guess... If anyone finds a way to make the target debuff durations work again, or get other addons like ClassicAuraDurations to work with luna let me know.

Kerzot · Answer 21 · 2023-09-05T17:09:01.000Z

Oh and to clarify, the party portraits have ? instead of default imagine when out of load range only when 3d is selected, 2d seems fine.

robmonte · Answer 22 · 2023-10-30T18:07:19.000Z

Can anyone here that's been applying any fixes to the addon to get it working open a fork repo we can share and contribute to?

caboyd · Answer 23 · 2023-11-15T12:24:59.000Z

Can anyone here that's been applying any fixes to the addon to get it working open a fork repo we can share and contribute to?

It has been done. #975

Share to