MacFrames

MacFrames

3.3k Downloads

Memory consumption rises over time.

JannesP opened this issue ยท 5 comments

commented

Compared to most other addons the rate is pretty bad. I need to check memeory usage in a raid environment to see if it gets worse.
I think it's my handling of auras, but I commenting out aura loading didn't prevent the rising memory usage.
The memory does get garbage collected though, so it's not a leak, probably just have to reuse more tables somewhere.

commented

Memory consumption is rising pretty fast in a 20 man raid. Probably gonna refactor my aura code to reuse all the tables.

commented

Still need to do more testing but memory consumption seems lower than before. It's still not perfect, so I have to dig a bit more. I'll also need to have a look at CPU time since I removed aura caching for UnitAuraBySlot in the process so I generate a lot more calls to that without having any Idea how expensive that is.

commented

CPU Time is fine for now, SUF still uses about 1/4th less but that seems to be alright. Memory consumption on the other hand is not fixed. Memory usage is reproduceable by changing the aura indicators from the settings while the test mode for the corresponding frames is active.

commented

So as it turns out, all inline functions cause a pretty big allocation of memory that is not freed like normal local variables. This means that in all repeatable code (event handlers, checks, etc.) those functions need to be declared as a scope local outside of a function.

commented

Fixed with 6aa398f. Hopefully the excessive memory usage is gone now.