Mappy Continued

Mappy Continued

6.5k Downloads

IndicatorFrame always showing button bg after checking mail

Shushuda opened this issue ยท 2 comments

commented

After the recent Blizz change to the mail icon (MinimapCluster.MailFrame -> MinimapCluster.IndicatorFrame), the mail icon still correctly disappears after checking the mail, but the background of the icon (the custom buttom generated by Mappy) remains on the minimap. Seems like the frame is still "rendered", but the icon itself is not. The Blizz-made icon disappears, but Mappy still sees the IndicatorFrame being rendered (just with no image), so it applies the button graphics.

TODO:

  • Look at the dungeon frames - they might use the same mechanism as the new IndicatorFrame. If so, try to adapt the button generation to not render when the icon inside the frame is missing. Not sure if possible tbh.

image

commented

Fixed, uploading a new release.

commented

Btw, the fix was to split MinimapCluster.IndicatorFrame into MinimapCluster.IndicatorFrame.MailFrame and MinimapCluster.IndicatorFrame.CraftingOrderFrame. The MailFrame works the same as the old MailFrame, with one difference - there's a line of code in Blizzard's Minimap.lua that tries to call frame's parent's Layout(). It's nil, probably because MailFrame is re-anchored in Mappy. I couldn't even find that function in the code, so I just overwrote it and it works? I might have introduced a taint, we will see.

That CraftingOrderFrame is new, btw. Pretty neat. I've put it into a separate button, I have no idea how default UI displays this button and I don't really care. It looks pretty as a separate button under mail, so it stays like that, lol.