MBB

MBB

1M Downloads

MBB doesn't correctly ignore pins from HandyNotes: Shadowlands

IKnewOne opened this issue ยท 9 comments

commented

Using MBB and HandyNotes: Shadowlands causes MBB to recognise icons for rare mobs as buttons, loading them up in the bag and freezing the game any time i try to use map/button bag.
image
image

Since this issue is between two addons i'll link the similar issue on the HandyNotes' addon issue page zarillion/handynotes-plugins#29

commented

Thanks for doing the work on this @IKnewOne and @BradCOnGitHub

commented

image
SInce i've used the same window in that issue, i'll add this here. This is a list of frames MBB uses as icons

commented

To make MBB compatible with my plugins, it would need to ignore all HandyNotes*Pin frames instead of just HandyNotesPin frames.

commented

Considering the info from the mod author, i've created the correspondening pull request
#14
Close the issue if you don't need any more info from me regarding this problem

commented

Mentioning this here as well as the above PR.

I would not go with the solution in #14. This will only ignore the pins from one of my plugins. I also have HandyNotes: Battle for Azeroth, which uses the pin names HandyNotes_BattleForAzerothPins. We have unreleased plugins for every expansion that we plan on releasing over time. That's why I mentioned the solution must ignore HandyNotes*Pins as a pattern to properly ignore them all.

commented

Replacing line 84 from:
[25] = "HandyNotesPin",
to:
[25] = "HandyNotes.*Pin",

Seems to do the trick. Pins aren't captured and there's no lag.

commented

Replacing line 84 from:
[25] = "HandyNotesPin",
to:
[25] = "HandyNotes.*Pin",

Seems to do the trick. Pins aren't captured and there's no lag.

Confirmed

commented

Changed the pull request to use this method instead, but resigned to using two lines both for main addon and the plugins to evade future possible problems

commented

I can confirm, after testing #14 locally all evening, this fixed the issue :)