MBB doesn't correctly ignore pins from HandyNotes: Shadowlands
IKnewOne opened this issue ยท 9 comments
Using MBB and HandyNotes: Shadowlands causes MBB to recognise icons for rare mobs as buttons, loading them up in the bag and freezing the game any time i try to use map/button bag.
Since this issue is between two addons i'll link the similar issue on the HandyNotes' addon issue page zarillion/handynotes-plugins#29
Thanks for doing the work on this @IKnewOne and @BradCOnGitHub
To make MBB compatible with my plugins, it would need to ignore all HandyNotes*Pin
frames instead of just HandyNotesPin
frames.
Considering the info from the mod author, i've created the correspondening pull request
#14
Close the issue if you don't need any more info from me regarding this problem
Mentioning this here as well as the above PR.
I would not go with the solution in #14. This will only ignore the pins from one of my plugins. I also have HandyNotes: Battle for Azeroth, which uses the pin names HandyNotes_BattleForAzerothPins. We have unreleased plugins for every expansion that we plan on releasing over time. That's why I mentioned the solution must ignore HandyNotes*Pins as a pattern to properly ignore them all.
Replacing line 84 from:
[25] = "HandyNotesPin",
to:
[25] = "HandyNotes.*Pin",
Seems to do the trick. Pins aren't captured and there's no lag.
Replacing line 84 from:
[25] = "HandyNotesPin",
to:
[25] = "HandyNotes.*Pin",
Seems to do the trick. Pins aren't captured and there's no lag.
Confirmed
Changed the pull request to use this method instead, but resigned to using two lines both for main addon and the plugins to evade future possible problems
I can confirm, after testing #14 locally all evening, this fixed the issue :)