Several Feature Requests
tusharsaxena opened this issue · 8 comments
First off, love this addon - been looking for something for a while (and didn't want to install the entire TSM package for just this). Had a bunch of small feature requests to make:
- Resizable window - especially the width, but ideally both axes
- Resizable columns
- Better ElvUI/AddonSkins integration (not sure if you or the ElvUI guys need to do this)
- Color code/column/filter for already known/already owned
- Color code/filter for cannot use/cannot learn
- Filters like in game merchant UI for class/spec/other filters
- Search box (search name and optionally tooltip?)
First off, love this addon - been looking for something for a while (and didn't want to install the entire TSM package for just this). Had a bunch of small feature requests to make:
I'm glad to hear this! I found TSM's UI seriously lacking and couldn't find any else that didn't just make the window wider without making it easier to use. I hope to keep iterating on this to make it more useful.
- Resizable window - especially the width, but ideally both axes
This isn't something I had originally planned but it shouldn't be that hard, at least horizontally. It'll probably just be a config slider rather than a drag action.
- Resizable columns
I need to build a custom interface for ordering columns still and setting their sizes could also be part of that.
I might also allow changing the text size and font so you can cram more columns in there.
- Better ElvUI/AddonSkins integration (not sure if you or the ElvUI guys need to do this)
I'll have to look into this. I honestly don't know anything about how they do it, and my UI is a mix of inherited base widgets and custom frames.
- Color code/column/filter for already known/already owned
- Color code/filter for cannot use/cannot learn
- Filters like in game merchant UI for class/spec/other filters
Filtering is planned but I need to build a UI for it. I've been thinking about color coding rows in case you don't enable the usable or available columns. Known is an interesting challenge because different types of items work differently but I'm planning to track this eventually.
- Search box (search name and optionally tooltip?)
Searching is planned as well.
See here for some of the stuff I'm planning to get to.
- Color code/column/filter for already known/already owned
Wanted to let you know that Known (being implemented as a column called Collectable
) will be coming with the 10.1.5.0 release on Tuesday. Due to the way that merchant and item data has changed over time, it's possible there are some issues with certain merchants, especially from expansions prior to Shadowlands. I'm going to need feedback to find corner cases.
There's no color coding to this column. It'll be icon indication only for now.
- Resizable window - especially the width, but ideally both axes
- Resizable columns
- Color code/filter for cannot use/cannot learn
These are next on deck. For the color coding I will initially just emulate the color coding behavior of the built-in Merchant UI.
P.S. I came across https://www.curseforge.com/wow/addons/sorted for bag management, idea's from that addon could also be used for the merchant frame
Interesting. I might actually use that, and will definitely consider some inspiration from it.
Hope you release a new version that has font customization options soon :)
I also use ElvUI and it replaces all of the fonts, including NumberFontNormal and derivatives thereof. And the infinite character isn't in most fonts so then it shows a stupid square :/
P.S. I came across https://www.curseforge.com/wow/addons/sorted for bag management, idea's from that addon could also be used for the merchant frame
Hope you release a new version that has font customization options soon :)
I also use ElvUI and it replaces all of the fonts, including NumberFontNormal and derivatives thereof. And the infinite character isn't in most fonts so then it shows a stupid square :/
I was testing with ElvUI and did not see any issue with the default ElvUI font and the infinity symbol. What font were you using?
On a related note, it turned out to be pretty easy, so, 10.1.5.2 includes support for ElvUI.
Not sure what I used before when I had that problem. ElvUI has a global font selector that styles both GameFontNormal and NumberFontNormal, so it's more of a problem with the font or ElvUI I guess. Maybe an option to just hide the infinite glyph or replace it with "0/0" even? I did that in my local copy of MerchantPlus:
DisplayFunctions.lua:
-- This display function shows an infinity symbol if the supply is infinite (-1)
function Display:Supply(data)
local key = self
if data[key] >= 0 then
return data[key]
else
--return "∞"
return ""
end
end