Addon not working since last update
HanaMobiyuki opened this issue · 15 comments
Since last 4.0.7 update, the addon is breaking all the minimap section, I am not able to click the minimap buttons and the minimap isn't loading
Getting back to previous version is working
I'm the author of the 4.0.7 change. I'm not seeing that problem, could you elaborate on any error messages or further descriptions of how its not working, including what other addons you are using?
Have you tried a "/mbb reset all" (w/o the double quotes) ?
I think I found the root of the problem. It's conflicting with ElvUI addon. @HanaMobiyuki @uofirob can you confirm that you use this addon?
Yes I do use ELVUI
Message: Interface\AddOns\MBB\MBB.lua:624: Action[SetPoint] failed because[Cannot anchor to a region dependent on it]: attempted from: MMHolder:SetPoint.
Time: Sat Jan 30 11:57:16 2021
Count: 6
Stack: Interface\AddOns\MBB\MBB.lua:624: Action[SetPoint] failed because[Cannot anchor to a region dependent on it]: attempted from: MMHolder:SetPoint.
[string "@interface\AddOns\TradeSkillMaster\LibTSM\Service\ErrorHandler.lua"]:758: in function <...Ons\TradeSkillMaster\LibTSM\Service\ErrorHandler.lua:717>
[string "=[C]"]: ?
[string "=[C]"]: in function osetpoint' [string "@Interface\AddOns\MBB\MBB.lua"]:624: in function MBB_SetPositions'
[string "@interface\AddOns\MBB\MBB.lua"]:751: in function `MBB_OnUpdate'
[string ":OnUpdate"]:1: in function <[string ":OnUpdate"]:1>
Locals: errMsg = "Interface\AddOns\MBB\MBB.lua:624: Action[SetPoint] failed because[Cannot anchor to a region dependent on it]: attempted from: MMHolder:SetPoint."
isBugGrabber = nil
tsmErrMsg = nil
oldModule = nil
private =
globalNameTranslation =
}
FormatErrorMessageSection = defined @interface\AddOns\TradeSkillMaster\LibTSM\Service\ErrorHandler.lua:517
ErrorHandler = defined @interface\AddOns\TradeSkillMaster\LibTSM\Service\ErrorHandler.lua:134
origErrorHandler = defined @interface\SharedXML\SharedBasicControls.lua:355
hitInternalError = false
CreateErrorFrame = defined @interface\AddOns\TradeSkillMaster\LibTSM\Service\ErrorHandler.lua:536
num = 0
SanitizeString = defined @interface\AddOns\TradeSkillMaster\LibTSM\Service\ErrorHandler.lua:510
AddonBlockedHandler = defined @interface\AddOns\TradeSkillMaster\LibTSM\Service\ErrorHandler.lua:502
GetStackLevelInfo = defined @interface\AddOns\TradeSkillMaster\LibTSM\Service\ErrorHandler.lua:344
ParseLocals = defined @interface\AddOns\TradeSkillMaster\LibTSM\Service\ErrorHandler.lua:396
ignoreErrors = false
errorReports =
}
IsTSMAddon = defined @interface\AddOns\TradeSkillMaster\LibTSM\Service\ErrorHandler.lua:478
localLinesTemp =
}
GetStackInfo = defined @interface\AddOns\TradeSkillMaster\LibTSM\Service\ErrorHandler.lua:313
}
MAX_STACK_DEPTH = 50
OLD_TSM_MODULES =
1 = "TradeSkillMaster_Accounting"
2 = "TradeSkillMaster_AuctionDB"
3 = "TradeSkillMaster_Auctioning"
4 = "TradeSkillMaster_Crafting"
5 = "TradeSkillMaster_Destroying"
6 = "TradeSkillMaster_Mailing"
7 = "TradeSkillMaster_Shopping"
8 = "TradeSkillMaster_Vendoring"
9 = "TradeSkillMaster_Warehousing"
}
FYI I don't use ELVUI.
Edit: /mbb buttons reports ...
MBB Buttons:
- LibDBIcon10_DBM
- LibDBIcon10_DungeonTols
- LibDBIcon10_Details
BagSync button is not listed.
@CosmicCleric me neither. We will need to look at why considering "OnMouseUp" events conflicted with ElvUI. Also, why BagSync is missing from "/mbb button" output.
EDIT:
For now, I reverted the changes.
The only guess I have to the problem is that the change has the existing code examining/pulling in more buttons than it used to. It'll probably need some refactoring to handle the new stuff it pulls in, which is kind of weird since its just buttons/icons, it should just handle them all the same way really.
Sorry for the extra work on a Saturday! :)
@CosmicCleric no problem at all. WoW has a large community and there are a lot of addons out there doing a lot of things and in different ways. It's impossible to test compatibility with all of them.
MBB has an old source code and maybe some things are not being done correctly, I need to be more careful in the future.
Either way, you reported a bug (MBB is not recognizing some buttons) and again I thank you for that and for your contribution :) We just need to find another way to fix it.
A user of curseforge commented error logs on the project page related to this issue. This can help in the future:
29x MBB\MBB-4.0.4.lua:624: Action[SetPoint] failed because[Cannot anchor to a region dependent on it]: attempted from: MMHolder:SetPoint. [string "=[C]"]: in functionosetpoint'
[string "@mbb\MBB-4.0.4.lua"]:624: in function MBB_SetPositions' [string "@MBB\MBB-4.0.4.lua"]:751: in function MBB_OnUpdate'
[string ":OnUpdate"]:1: in function <[string ":OnUpdate"]:1>
Locals:
(*temporary) = MMHolder {
0 =
ohide = defined =[C]:-1
isvisible = true
SetHeight = defined =[C]:-1
oclearallpoints = defined =[C]:-1
SetSize = defined =[C]:-1
SetPoint = defined @mbb\MBB.lua:516
Hide = defined @mbb\MBB.lua:402
ClearAllPoints = defined @mbb\MBB.lua:514
parentisvisible = true
mover = MinimapMover {
}
Show = defined @mbb\MBB.lua:385
SetWidth = defined =[C]:-1
osize =
}
oshow = defined =[C]:-1
osetpoint = defined =[C]:-1
opoint =
}
}
(*temporary) = "RIGHT"
(*temporary) = MinimapPanel {
0 =
isvisible = true
osetpoint = defined =[C]:-1
OnBackdropLoaded = defined @SharedXML\Backdrop.lua:195
GetBackdropColor = defined @SharedXML\Backdrop.lua:433
anchor = "ANCHOR_BOTTOM"
TopLeftCorner = {
}
RightEdge = {
}
Hide = defined @mbb\MBB.lua:402
template = "Default"
parentisvisible = true
ApplyBackdrop = defined @SharedXML\Backdrop.lua:337
SetBackdrop = defined @SharedXML\Backdrop.lua:372
dataPanels =
}
Show = defined @mbb\MBB.lua:385
GetBackdropBorderColor = defined @SharedXML\Backdrop.lua:452
GetBackdrop = defined @SharedXML\Backdrop.lua:390
osize =
}
glossTex = true
SetBorderBlendMode = defined @SharedXML\Backdrop.lua:309
ohide = defined =[C]:-1
PixelSnapDisabled = true
oclearallpoints = defined =[C]:-1
oenter = defined @ElvUI\Modules\DataTexts\DataTexts.lua:118
Center = {
}
opoint =
}
backdropInfo =
}
OnBackdropSizeChanged = defined @SharedXML\Backdrop.lua:225
HasBackdropInfo = defined @SharedXML\Backdrop.lua:321
oleave = defined @ElvUI\Modules\DataTexts\DataTexts.lua:135
SetPoint = defined @mbb\MBB.lua:516
numPoints = 2
ClearAllPoints = defined @mbb\MBB.lua:514
GetEdgeSize = defined @SharedXML\Backdrop.lua:231
ClearBackdrop = defined @SharedXML\Backdrop.lua:325
BottomEdge = {
}
TopEdge = {
}
BottomRightCorner = {
}
BottomLeftCorner = {
}
SetupTextureCoordinates = defined @SharedXML\Backdrop.lua:257
yOff = -4
xOff = 0
oshow = defined =[C]:-1
SetBackdropBorderColor = defined @SharedXML\Backdrop.lua:465
SetupPieceVisuals = defined @SharedXML\Backdrop.lua:289
SetBackdropColor = defined @SharedXML\Backdrop.lua:442
LeftEdge = {
}
TopRightCorner = {
}
}
(*temporary) = "LEFT"
(*temporary) = 0
(*temporary) = 0
`
Quick follow-up question. Is the addon basically just detaching a child button from its parent frame and adding it to another parent frame, or is it reconstructing the child button from scratch?
Its breaking my ElvUI Minimap. I just updated it at approximately 3PM PST 2020/1/30.
no other addons updated
I have to disable either the minimap in ElvUI or MinimapButtonBag otherwise my minimap is almost in the middle of the screen
Latest version 4.0.8 fixed my problem, thank you for you hard work on a saturday
Latest version 4.0.8 fixed my problem, thank you for you hard work on a saturday
Ditto
For those who are interested in following up on the bug that version 4.0.7 tried to fix there's this issue: #6