Minimap Button Frame Redux

Minimap Button Frame Redux

7.9k Downloads

buttons wont group since ace 3 update

Yuno951 opened this issue ยท 8 comments

commented

image

commented

the box in the top right is the button frame when i close it the buttons disappear
image

commented

What version of Ace3 is causing this?
I'm using Release-r1320 locally for testing, and I can't reproduce this.

Are you seeing any Lua errors?

commented

image
what ever the latest version and thats the only error im getting

commented

Hmm, I don't think this is a problem with Ace or MBF. I looked at what's happening at 1077 and it's just trying to turn to lowercase the name of all the frames, but its getting passed a frame with nil for the name.

I think I can add a check to work around this issue, but I don't believe something's supposed to be creating minimap buttons with nil frame names.

I'll look into the best way to work around this, but without something triggering it, it's not going to be easy to test, so if you could by any chance let me know which addon is doing that, I can install that and see how best to fix. I'm thinking I should just return false if its nil, but I need to double check.

commented

maybe elvui latest update then?

EDIT: yea just disabled elvui and it fixed itself

would like to be able to use both :D

commented

It does appear to be elvui.

It will be a moment before I can get this updated, but I found what should work with a quick test.

On line 1077 of MinimapButtonFrameRedux.lua change

if (strlower(v) == strlower(frameName)) then  

to

if frameName ~= nil and (strlower(v) == strlower(frameName)) then

I gotta do a TOC bump release which I'll put that in when I do... soonish, but if you make that edit to your copy, you should be good.

commented

Please let me know if that change fixes it for you

commented

Ya sorry I went to sleep and changed it when I woke up forgot to reply here that the change fixed the issue