Mission Report Button Plus

Mission Report Button Plus

24.2k Downloads

Error in settings

zaphon opened this issue ยท 4 comments

commented

About 1.5 hours ago or so I got a hotfix (yes at like 5:30pm on a Friday night Blizzard time), and started getting the below error on login. I commented out lines 1302/1303 for now to at least skip the error on login.

5x .../Blizzard_Settings_Shared/Blizzard_SettingsPanel.lua:663: Setting variable 'menuTextFont' was previously registered.
[string "=[C]"]: in function `error'
[string "@Blizzard_Settings_Shared/Blizzard_SettingsPanel.lua"]:663: in function `RegisterSetting'
[string "@Blizzard_Settings_Shared/Blizzard_SettingsInbound.lua"]:198: in function <...lizzard_Settings_Shared/Blizzard_SettingsInbound.lua:155>
[string "=[C]"]: in function `SetAttribute'
[string "@Blizzard_Settings_Shared/Blizzard_SettingsInbound.lua"]:98: in function <...lizzard_Settings_Shared/Blizzard_SettingsInbound.lua:97>
[string "=(tail call)"]: ?
[string "@MissionReportButtonPlus/MissionReportButtonPlus_Options.lua"]:244: in function <...ReportButtonPlus/MissionReportButtonPlus_Options.lua:238>
[string "@MissionReportButtonPlus/MissionReportButtonPlus_Options.lua"]:518: in function <...ReportButtonPlus/MissionReportButtonPlus_Options.lua:513>
[string "@MissionReportButtonPlus/MissionReportButtonPlus_Options.lua"]:1302: in function `MRBP_Settings_Register'
[string "@MissionReportButtonPlus/MissionReportButtonPlus.lua"]:334: in function `OnLoad'
[string "@MissionReportButtonPlus/MissionReportButtonPlus.lua"]:114: in function <.../MissionReportButtonPlus/MissionReportButtonPlus.lua:107>

Locals:
(*temporary) = "Setting variable 'menuTextFont' was previously registered."

Gethe/wow-ui-source@b123687#diff-62226fc0a02deb129d089a52c6214aa499ab529f82d2a7d87c4842d0293f53c9

That's the change that Blizzard pushed that caused it.

commented

Getting two errors myself:

Message: .../Blizzard_Settings_Shared/Blizzard_SettingsPanel.lua:663: Setting variable 'menuTextFont' was previously registered.
Time: Sat Aug 17 04:36:30 2024
Count: 1
Stack: .../Blizzard_Settings_Shared/Blizzard_SettingsPanel.lua:663: Setting variable 'menuTextFont' was previously registered.
[string "@Interface/AddOns/Blizzard_Settings_Shared/Blizzard_SettingsPanel.lua"]:663: in function `RegisterSetting'
[string "@Interface/AddOns/Blizzard_Settings_Shared/Blizzard_SettingsInbound.lua"]:198: in function <...lizzard_Settings_Shared/Blizzard_SettingsInbound.lua:155>
[string "=[C]"]: in function `SetAttribute'
[string "@Interface/AddOns/Blizzard_Settings_Shared/Blizzard_SettingsInbound.lua"]:98: in function <...lizzard_Settings_Shared/Blizzard_SettingsInbound.lua:97>
[string "=(tail call)"]: ?
[string "@Interface/AddOns/MissionReportButtonPlus/MissionReportButtonPlus_Options.lua"]:244: in function <...ReportButtonPlus/MissionReportButtonPlus_Options.lua:238>
[string "@Interface/AddOns/MissionReportButtonPlus/MissionReportButtonPlus_Options.lua"]:518: in function <...ReportButtonPlus/MissionReportButtonPlus_Options.lua:513>
[string "@Interface/AddOns/MissionReportButtonPlus/MissionReportButtonPlus_Options.lua"]:1302: in function `MRBP_Settings_Register'
[string "@Interface/AddOns/MissionReportButtonPlus/MissionReportButtonPlus.lua"]:334: in function `OnLoad'
[string "@Interface/AddOns/MissionReportButtonPlus/MissionReportButtonPlus.lua"]:114: in function <.../MissionReportButtonPlus/MissionReportButtonPlus.lua:107>

Locals: self = SettingsPanel {
 GameTab = Button {
 }
 categoryLayouts = <table> {
 }
 ClosePanelButton = Button {
 }
 QuestTextPreview = Frame {
 }
 CategoryList = Frame {
 }
 SearchBox = EditBox {
 }
 modified = <table> {
 }
 AddOnsTab = Button {
 }
 Bg = Frame {
 }
 NineSlice = Frame {
 }
 tabsGroup = <table> {
 }
 settings = <table> {
 }
 InputBlocker = Frame {
 }
 Container = Frame {
 }
 ApplyButton = Button {
 }
 OutputText = FontString {
 }
 CloseButton = Button {
 }
}
category = <table> {
 order = 8
 ID = "MissionReportButtonPlusAppearanceSettings"
 parentCategory = <table> {
 }
 name = "Appearance"
 subcategories = <table> {
 }
}
setting = <table> {
 variableTbl = <table> {
 }
 name = "Font (Part 2)"
 defaultValue = "GameTooltipText"
 variableKey = "menuTextFont"
 commitFlags = 0
 variable = "menuTextFont"
 variableType = "string"
}
success = false
variable = "menuTextFont"
Message: ...ReportButtonPlus/MissionReportButtonPlus_Options.lua:547: attempt to call method 'SetValue' (a nil value)
Time: Sat Aug 17 04:36:30 2024
Count: 1
Stack: ...ReportButtonPlus/MissionReportButtonPlus_Options.lua:547: attempt to call method 'SetValue' (a nil value)
[string "@Interface/AddOns/MissionReportButtonPlus/MissionReportButtonPlus_Options.lua"]:547: in function <...ReportButtonPlus/MissionReportButtonPlus_Options.lua:513>
[string "@Interface/AddOns/MissionReportButtonPlus/MissionReportButtonPlus_Options.lua"]:1302: in function `MRBP_Settings_Register'
[string "@Interface/AddOns/MissionReportButtonPlus/MissionReportButtonPlus.lua"]:334: in function `OnLoad'
[string "@Interface/AddOns/MissionReportButtonPlus/MissionReportButtonPlus.lua"]:114: in function <.../MissionReportButtonPlus/MissionReportButtonPlus.lua:107>

Locals: category = <table> {
 order = 8
 ID = "MissionReportButtonPlusAppearanceSettings"
 parentCategory = <table> {
 }
 name = "Appearance"
 subcategories = <table> {
 }
}
variableName = "menuTextFont"
valueList = <table> {
 1 = <table> {
 }
 2 = <table> {
 }
 3 = <table> {
 }
 4 = <table> {
 }
 5 = <table> {
 }
 6 = <table> {
 }
 7 = <table> {
 }
 8 = <table> {
 }
 9 = <table> {
 }
 10 = <table> {
 }
 11 = <table> {
 }
 12 = <table> {
 }
 13 = <table> {
 }
 14 = <table> {
 }
 15 = <table> {
 }
 16 = <table> {
 }
 17 = <table> {
 }
 18 = <table> {
 }
 19 = <table> {
 }
 20 = <table> {
 }
 21 = <table> {
 }
 22 = <table> {
 }
 23 = <table> {
 }
 24 = <table> {
 }
 25 = <table> {
 }
 26 = <table> {
 }
 27 = <table> {
 }
 28 = <table> {
 }
 29 = <table> {
 }
 30 = <table> {
 }
 31 = <table> {
 }
 32 = <table> {
 }
 33 = <table> {
 }
 34 = <table> {
 }
 35 = <table> {
 }
 36 = <table> {
 }
 37 = <table> {
 }
 38 = <table> {
 }
 39 = <table> {
 }
 40 = <table> {
 }
 41 = <table> {
 }
 42 = <table> {
 }
 43 = <table> {
 }
 44 = <table> {
 }
 45 = <table> {
 }
 46 = <table> {
 }
 47 = <table> {
 }
 48 = <table> {
 }
 49 = <table> {
 }
 50 = <table> {
 }
 51 = <table> {
 }
 52 = <table> {
 }
 53 = <table> {
 }
 54 = <table> {
 }
 55 = <table> {
 }
 56 = <table> {
 }
 57 = <table> {
 }
 58 = <table> {
 }
 59 = <table> {
 }
 60 = <table> {
 }
 61 = <table> {
 }
 62 = <table> {
 }
 63 = <table> {
 }
 64 = <table> {
 }
 65 = <table> {
 }
 66 = <table> {
 }
 67 = <table> {
 }
 68 = <table> {
 }
 69 = <table> {
 }
 70 = <table> {
 }
 71 = <table> {
 }
 72 = <table> {
 }
 73 = <table> {
 }
 74 = <table> {
 }
 75 = <table> {
 }
 76 = <table> {
 }
 77 = <table> {
 }
 78 = <table> {
 }
 79 = <table> {
 }
 80 = <table> {
 }
 81 = <table> {
 }
 82 = <table> {
 }
 83 = <table> {
 }
 84 = <table> {
 }
 85 = <table> {
 }
 86 = <table> {
 }
 87 = <table> {
 }
 88 = <table> {
 }
 89 = <table> {
 }
 90 = <table> {
 }
 91 = <table> {
 }
 92 = <table> {
 }
 93 = <table> {
 }
 94 = <table> {
 }
 95 = <table> {
 }
 96 = <table> {
 }
 97 = <table> {
 }
 98 = <table> {
 }
 99 = <table> {
 }
 100 = <table> {
 }
}
defaultText = "Font (Part 2)"
tooltip = "Blizzard provides a huge amount of predefined fonts.
Choose here the font of your liking."
defaultValue = "GameTooltipText"
currentValue = "GameTooltipText"
varType = "string"
setting = <table> {
 searchTags = <table> {
 }
 data = <table> {
 }
 frameTemplate = "SettingsDropdownControlTemplate"
}
defaultValueTooltip = "Blizzard provides a huge amount of predefined fonts.
Choose here the font of your liking.

Default: GameTooltipText"
initializer = <table> {
 searchTags = <table> {
 }
 data = <table> {
 }
 frameTemplate = "SettingsDropdownControlTemplate"
}
(*temporary) = nil
(*temporary) = <table> {
 searchTags = <table> {
 }
 data = <table> {
 }
 frameTemplate = "SettingsDropdownControlTemplate"
}
(*temporary) = "GameTooltipText"
(*temporary) = "attempt to call method 'SetValue' (a nil value)"
ns = <table> {
 mapUtil = <table> {
 }
 settingsMenuEntry = "99"
 LandingPageInfo = <table> {
 }
 utilities = <table> {
 }
 DragonridingUtil = <table> {
 }
 AddonTitleSeparator = ":"
 poiUtil 
commented

I got a hotfix (yes at like 5:30pm on a Friday night Blizzard time),

I wondered what was so important they were pushing that out before a weekend... looks like client-side fallout of bank deposit fixes and some better nil checking, at a quick glance.

commented

Hi guys, thank you for reporting this!
I just logged into the game myself and saw this problem. Good news is, it only effects the settings, the rest of the addon seems to work just fine. I'll try to fix the settings issue as quick as possible, starting now.
@zaphon Thanks for the link to the changes. I'm sure this will help a lot.

commented

Ok, fixed. โœŒ๏ธ
This took me longer than I expected tbh, but it works now.
The problem was Blizzard no longer allows to register 1 variable for multiple setting controls, which was the problem in my case.

@F-Lambda The 'SetValue' (a nil value) issue war collateral since it blocked the variable to be registered a 2nd time.