Mission Report Button Plus

Mission Report Button Plus

24.2k Downloads

In retail version 10.1, SetNewTagShown is nil

SpareSimian opened this issue ยท 3 comments

commented
Message: ...ReportButtonPlus/MissionReportButtonPlus_Options.lua line 313:
   attempt to call method 'SetNewTagShown' (a nil value)
Debug:
   [string "@Interface/AddOns/MissionReportButtonPlus/MissionReportButtonPlus_Options.lua"]:313:
      ...ReportButtonPlus/MissionReportButtonPlus_Options.lua:307
   [string "@Interface/AddOns/MissionReportButtonPlus/MissionReportButtonPlus_Options.lua"]:749: MRBP_Settings_Register()
   [string "@Interface/AddOns/MissionReportButtonPlus/MissionReportButtonPlus.lua"]:287: OnLoad()
   [string "@Interface/AddOns/MissionReportButtonPlus/MissionReportButtonPlus.lua"]:81:
      .../MissionReportButtonPlus/MissionReportButtonPlus.lua:74
Locals:
category = <table> {
 GetID = <function> defined @Interface/SharedXML/Settings/Blizzard_Category.lua:13
 SetCategorySet = <function> defined @Interface/SharedXML/Settings/Blizzard_Category.lua:53
 order = 8
 HasSubcategories = <function> defined @Interface/SharedXML/Settings/Blizzard_Category.lua:72
 GetOrder = <function> defined @Interface/SharedXML/Settings/Blizzard_Category.lua:25
 SetParentCategory = <function> defined @Interface/SharedXML/Settings/Blizzard_Category.lua:45
 HasParentCategory = <function> defined @Interface/SharedXML/Settings/Blizzard_Category.lua:49
 SetOrder = <function> defined @Interface/SharedXML/Settings/Blizzard_Category.lua:29
 ID = "MissionReportButtonPlus"
 Init = <function> defined @Interface/SharedXML/Settings/Blizzard_Category.lua:6
 GetParentCategory = <function> defined @Interface/SharedXML/Settings/Blizzard_Category.lua:41
 GetName = <function> defined @Interface/SharedXML/Settings/Blizzard_Category.lua:17
 categorySet = 2
 name = "MissionReportButtonPlus"
 SetName = <function> defined @Interface/SharedXML/Settings/Blizzard_Category.lua:21
 subcategories = <table> {
 }
 CreateSubcategory = <function> defined @Interface/SharedXML/Settings/Blizzard_Category.lua:76
 GetQualifiedName = <function> defined @Interface/SharedXML/Settings/Blizzard_Category.lua:33
 GetSubcategories = <function> defined @Interface/SharedXML/Settings/Blizzard_Category.lua:68
 GetCategorySet = <function> defined @Interface/SharedXML/Settings/Blizzard_Category.lua:57
}
checkBoxList = <table> {
 1 = <table> {
 }
 2 = <table> {
 }
 3 = <table> {
 }
 4 = <table> {
 }
 5 = <table> {
 }
 6 = <table> {
 }
 7 = <table> {
 }
}
data = <table> {
  = <table> {
 }
  = <table> {
 }
  = <table> {
 }
  = <table> {
 }
  = <table> {
 }
  = <table> {
 }
}
(for generator) = <function> defined =[C]:-1
(for state) = <table> {
 1 = <table> {
 }
 2 = <table> {
 }
 3 = <table> {
 }
 4 = <table> {
 }
 5 = <table> {
 }
 6 = <table> {
 }
 7 = <table> {
 }
}
(for control) = 7
i = 7
cb = <table> {
 modifyPredicate = <function> defined @Interface/AddOns/MissionReportButtonPlus/MissionReportButtonPlus_Options.lua:562
 name = "Island Expeditions"
 variable = "showBfAIslandExpeditionsInfo"
 tooltip = "Shows the amount of Azerite you collected from the Island Expeditions."
 tag = true
}
setting = <table> {
 GetOriginalValue = <function> defined @Interface/SharedXML/Settings/Blizzard_Setting.lua:92
 SetCommitOrder = <function> defined @Interface/SharedXML/Settings/Blizzard_Setting.lua:100
 SetNewTagShown = <function> defined @Interface/SharedXML/Settings/Blizzard_Setting.lua:168
 RemoveCommitFlag = <function> defined @Interface/SharedXML/Settings/Blizzard_Setting.lua:114
 SetValueToDefault = <function> defined @Interface/SharedXML/Settings/Blizzard_Setting.lua:150
 GetName = <function> defined @Interface/SharedXML/Settings/Blizzard_Setting.lua:38
 GetValueInternal = <function> defined @Interface/SharedXML/Settings/Blizzard_Setting.lua:313
 GetVariable = <function> defined @Interface/SharedXML/Settings/Blizzard_Setting.lua:42
 name = "Island Expeditions"
 HasCommitFlag = <function> defined @Interface/SharedXML/Settings/Blizzard_Setting.lua:120
 SetCommitFlags = <function> defined @Interface/SharedXML/Settings/Blizzard_Setting.lua:104
 ReinitializeValue = <function> defined @Interface/SharedXML/Settings/Blizzard_Setting.lua:79
 IsNewTagShown = <function> defined @Interface/SharedXML/Settings/Blizzard_Setting.lua:164
 Commit = <function> defined @Interface/SharedXML/Settings/Blizzard_Setting.lua:140
 SetValueInternal = <function> defined @Interface/SharedXML/Settings/Blizzard_Setting.lua:304
 SetIgnoreApplyOverride = <function> defined @Interface/SharedXML/Settings/Blizzard_Setting.lua:124
 internalValue = true
 AddCommitFlag = <function> defined @Interface/SharedXML/Settings/Blizzard_Setting.lua:110
 commitFlags = 0
 defaultValue = true
 Init = <function> defined @Interface/SharedXML/Settings/Blizzard_Setting.lua:297
 GetVariableType = <function> defined @Interface/SharedXML/Settings/Blizzard_Setting.lua:46
 GetCommitOrder = <function> defined @Interf
commented

The Settings object is created at line 285 by Settings.CreateCheckBox. I'm guessing something in that API changed. I haven't chased it further up. Is Settings a Blizzard namespace? It lacks the "C_" I'm used to seeing in their namespaces.

commented

SetNewTagShown no longer exists, see SharedXML/Settings/Blizzard_SettingsControls.lua. IsNewTagShown is now implemented in terms of the specific setting object.

https://github.com/Gethe/wow-ui-source/blob/live/Interface/SharedXML/Settings/Blizzard_SettingControls.lua

commented

Fixed. It's like you said @SpareSimian, Blizzard moved SetNewTagShown from the initializer class to the settings.
Thanks for reporting this.