Describe the bug

How to reproduce

DE some item

What did you expect?

Screenshots

50x Molinari/api/items.lua:62: attempt to compare number with nil
[string "@Molinari/api/items.lua"]:62: in function IsDisenchantable' [string "@Molinari/api/items.lua"]:115: in function IsSalvagable'
[string "@Molinari/addon.lua"]:41: in function <Molinari/addon.lua:8>
[string "@Molinari/utils.lua"]:56: in function <Molinari/utils.lua:47>
[string "=[C]"]: ?
[string "=[C]"]: ?
[string "=[C]"]: ?
[string "=[C]"]: ?
[string "=[C]"]: ?
[string "=[C]"]: ?
[string "=[C]"]: ?
[string "@Ace3/AceHook-3.0-9/AceHook-3.0.lua"]:95: in function <Ace3/AceHook-3.0/AceHook-3.0.lua:87>
[string "=[C]"]: ?
[string "=[C]"]: ?
[string "=[C]"]: ?
[string "=[C]"]: in function SetBagItem' [string "@FrameXML/ContainerFrame_Shared.lua"]:1362: in function UpdateTooltip'

• Which item?
• What's your enchanting skill level?

Wotlk classic. Already de-ed it so dont remember exact item, but it happened again so ill try to write down some example. Max enchanting.

probably there is some conflict with Gargul addon, its pop roll window with alt-click. but most of the time it works fine, then on random item stop working with error

enchanting: Enchanting nil 136244 0 0 0 7411
nil Class Skills
nil Assassination
nil Combat
nil Lockpicking
nil Subtlety
nil Professions
nil Enchanting
nil Engineering
nil Secondary Skills
nil Cooking
nil First Aid
nil Fishing
nil Riding
nil Weapon Skills
nil Axes
nil Bows
nil Crossbows
nil Daggers
nil Defense
nil Guns
nil Maces
nil Swords
nil Thrown
nil Unarmed
nil Armor Proficiencies
nil Cloth
nil Leather
nil Languages
nil Language: Common

Please run this command and show me its output, a screenshot is fine.

/run print('enchanting:' (GetSpellInfo(7411))); for i=1,GetNumSkillLines() do print(index, (GetSkillLineInfo(i))) end

Please try out this alpha version for a few days and let me know if it works fine:
https://github.com/p3lim-wow/Molinari/suites/13797649901/artifacts/765108329

There might be issues with it not correctly identifying items to disenchant, but I can't say for sure as I don't play classic/wrath and can't test it.

Good news - there is no error anymore :) Bad news - it still doesn't DE some items and just pop Gargul roll window. From items i have in bags The Black Book and Abyss Shard works fine, but Touch of the Occult and Abyssal Rune dont work, popping Gargul window instead.

Are the sparkles around the item shown, even when Gargul would respond to the alt+click?

While holding the alt key over an item in your bags you could also run this command to verify if Molinari is actually supposed to work:

/dump GameTooltip:GetOwner():GetDebugName()

No sparks on items which doesnt work. Also different debug output

not working item
Dump: value=GameTooltip:GetOwner():GetDebugName()
[1]="AdiBagsItemButton141"

working item
Dump: value=GameTooltip:GetOwner():GetDebugName()
[1]="Molinari"

Ah ok, so Gargul doesn't seem to prevent Molinari atleast, that's good.

Could you give me the output of these three commands? They might be lengthy.

/dump GetItemInfo(19337)
/dump GetItemInfo(20534)
/dump GetItemInfo(47213)
/dump GetItemInfo(45840)

And this one, just so I can be sure:

/dump GetAddOnMetadata('Molinari', 'Version')

Thanks, please try this alpha version:
https://github.com/p3lim-wow/Molinari/suites/13797649901/artifacts/765108329

Dump: value=GetItemInfo(19337)
[1]="The Black Book",
[2]="||Hitem:19337::::::::80:::::::::|h[The Black Book]|h|",
[3]=4,
[4]=76,
[5]=60,
[6]="Armor",
[7]="Miscellaneous",
[8]=1,
[9]="INVTYPE_TRINKET",
[10]=133738,
[11]=72039,
[12]=4,
[13]=0,
[14]=1,
[15]=254,
[17]=false

Dump: value=GetItemInfo(20534)
[1]="Abyss Shard",
[2]="||Hitem:20534::::::::80:::::::::|h[Abyss Shard]|h|",
[3]=3,
[4]=52,
[5]=0,
[6]="Armor",
[7]="Miscellaneous",
[8]=1,
[9]="INVTYPE_TRINKET",
[10]=134072,
[11]=3975,
[12]=4,
[13]=0,
[14]=1,
[15]=254,
[17]=false

Dump: value=GetItemInfo(47213)
[1]="Abyssal Rune",
[2]="||Hitem:47213::::::::80:::::::::|h[Abyssal Rune]|h|",
[3]=4,
[4]=200,
[5]=80,
[6]="Armor",
[7]="Miscellaneous",
[8]=1,
[9]="INVTYPE_TRINKET",
[10]=134422,
[11]=107343,
[12]=4,
[13]=0,
[14]=1,
[15]=254,
[17]=false

Dump: value=GetItemInfo(45840)
[1]="Touch of the Occult",
[2]="||Hitem:45840::::::::80:::::::::|h[Touch of the Occult]|h|",
[3]=4,
[4]=232,
[5]=80,
[6]="Armor",
[7]="Cloth",
[8]=1,
[9]="INVTYPE_HAND",
[10]=132951,
[11]=0,
[12]=4,
[13]=1,
[14]=1,
[15]=254,
[17]=false

Dump: value=GetAddOnMetadata('Molinari', 'Version')
[1]="9ca188f"

Touch works now, but Abyssal Rune still doesnt and no glow.

I know why too, I'll see if I can find a better way to detect an item's expansion level somehow.

https://github.com/p3lim-wow/Molinari/suites/13799454319/artifacts/765250922

This alpha version should def work, I'll get it ready for a release as soon as you can confirm that.

Everything works now! Thanks a lot!