Molinari

Molinari

Addons
1M Downloads

Skill check in SoD

GregoryGH opened this issue ยท 5 comments

commented

Doesnt disenchant higher ilvl items in SoD with lvl 5 char. Seems got skill check, but its not needed in classic.

commented

Not sure what you mean about this, I don't play SoD, so you'll need to be more descriptive.

As far as I know, you'll need a certain skill level of enchanting to disenchant items of different item levels. The current list is based loosely on this page: https://www.wow-professions.com/wotlk/disenchanting-tables-wotlk-classic

commented
commented

Been experiencing this as well (in SOD). Using Molinari, I wasn't able to disenchant a lv 25 shield on my disenchanting alt (level 5). At first I thought it was the change they had made in TBC that required higher skill level to DE higher level items.

To double-check, I tried using the regular disenchant button from the skill book, which ended up working. It seems Molinari is disabling higher level items somehow.

commented

Yes, please fix that :C

commented

Hackfix is here, edit Molinari/api/skill.lua - delete everything and paste that:

local _, addon = ...

if addon:IsRetail() then
	local professionSkillLines = {}

	function addon:PLAYER_LOGIN()
		for _, skillLineID in next, C_TradeSkillUI.GetAllProfessionTradeSkillLines() do
			local skillInfo = C_TradeSkillUI.GetProfessionInfoBySkillLineID(skillLineID)
			if skillInfo.parentProfessionID and skillInfo.isPrimaryProfession then
				if not professionSkillLines[skillInfo.parentProfessionID] then
					professionSkillLines[skillInfo.parentProfessionID] = {}
				end

				professionSkillLines[skillInfo.parentProfessionID][skillLineID] = true
			end
		end
	end

	local skillLineLevels = {}
	local function updateSkillLines()
		for _, skillLines in next, professionSkillLines do
			for skillLineID in next, skillLines do
				local skillInfo = C_TradeSkillUI.GetProfessionInfoBySkillLineID(skillLineID)
				if skillInfo.maxSkillLevel > 0 then
					skillLineLevels[skillLineID] = skillInfo.skillLevel
				else
					skillLineLevels[skillLineID] = nil
				end
			end
		end
	end

	addon:RegisterEvent('PLAYER_LOGIN', updateSkillLines)
	addon:RegisterEvent('TRADE_SKILL_SHOW', updateSkillLines)
	addon:RegisterEvent('SKILL_LINES_CHANGED', updateSkillLines)
	addon:RegisterEvent('TRADE_SKILL_LIST_UPDATE', updateSkillLines)

	function addon:GetProfessionSkillLevel(skillLineID)
		return skillLineLevels[skillLineID] or 0
	end
else
	local PROFESSION_IDS = {
		-- these are all the apprentice-level spells, except herbalism since there's no matching
		-- apprentice skill for it, an item effect is used instead
		[(GetSpellInfo(2259))] = 171, -- Alchemy
		[(GetSpellInfo(2018))] = 164, -- Blacksmithing
		[(GetSpellInfo(7411))] = 333, -- Enchanting
		[(GetSpellInfo(4036))] = 202, -- Engineering
		[(GetSpellInfo(9134))] = 182, -- Herbalism
		[(GetSpellInfo(45357)) or 0] = 773, -- Inscription
		[(GetSpellInfo(25229)) or 0] = 755, -- Jewelcrafting
		[(GetSpellInfo(2108))] = 165, -- Leatherworking
		[(GetSpellInfo(2575))] = 186, -- Mining
		[(GetSpellInfo(8613))] = 393, -- Skinning
		[(GetSpellInfo(3908))] = 197, -- Tailoring
	}

	local professionSkillLevels = {}
	function addon:GetProfessionSkillLevel(professionID)
		return professionSkillLevels[professionID] or 0
	end

	function addon:SKILL_LINES_CHANGED()
		table.wipe(professionSkillLevels) -- we have to do this in case the player unlearns a profession

		for index = 1, GetNumSkillLines() do
			local skillName, isHeader, isExpanded, skillLevel = GetSkillLineInfo(index)
			if skillName == _G.TRADE_SKILLS and isHeader and not isExpanded then
				ExpandSkillHeader(index)
				return
			else
				local professionID = PROFESSION_IDS[skillName]
				if professionID then
					professionSkillLevels[professionID] = skillLevel
				end
			end
		end
	end

	function addon:RequiredDisenchantingLevel(itemID)
		local _, _, _, _, itemRequiredLevel = GetItemInfo(itemID)
		if not itemRequiredLevel then
			return
		end

		-- this is pretty much pure guesswork and probably won't be entirely accurate
		if itemRequiredLevel <= 15 then
			return 1
		elseif itemRequiredLevel <= 20 then
			return 1
		elseif itemRequiredLevel <= 25 then
			return 1
		elseif itemRequiredLevel <= 30 then
			return 1
		elseif itemRequiredLevel <= 35 then
			return 1
		elseif itemRequiredLevel <= 40 then
			return 1
		elseif itemRequiredLevel <= 45 then
			return 1
		elseif itemRequiredLevel <= 50 then
			return 1
		elseif itemRequiredLevel <= 55 then
			return 1
		elseif itemRequiredLevel <= 63 then
			return 1
		elseif itemRequiredLevel <= 70 then
			return 1
		elseif itemRequiredLevel <= 72 then
			return 1
		elseif itemRequiredLevel <= 80 then
			return 1
		else
			return 9999 -- fallback to avoid errors without information available
		end
	end
end