BetterBags Issues with Disenchanting
Thunderpain opened this issue · 11 comments
With the BetterBags addon installed and enabled bugrabber catches the below listed error when trying to DE items with alt+left click.
6x Molinari/addon.lua:162: attempt to compare number with nil
[string "@Molinari/addon.lua"]:162: in function <Molinari/addon.lua:161>
[string "=[C]"]: ?
[string "@Molinari/addon.lua"]:187: in function callback'
[string "@Molinari/libs/Dashi/modules/event.lua"]:92: in function TriggerEvent'
[string "@Molinari/libs/Dashi/modules/event.lua"]:101: in function <Molinari/libs/Dashi/modules/event.lua:100>
Locals:
self = Molinari {
0 =
ApplySpell = defined @Molinari/addon.lua:56
IsEventRegistered = defined @Molinari/libs/Dashi/modules/event.lua:76
TriggerCombatEvent = defined @Molinari/libs/Dashi/modules/event.lua:219
RegisterCombatEvent = defined @Molinari/libs/Dashi/modules/event.lua:224
RegisterUnitEvent = defined @Molinari/libs/Dashi/modules/event.lua:118
UnregisterUnitEvent = defined @Molinari/libs/Dashi/modules/event.lua:150
TriggerEvent = defined @Molinari/libs/Dashi/modules/event.lua:89
RegisterEvent = defined @Molinari/libs/Dashi/modules/event.lua:40
TriggerUnitEvent = defined @Molinari/libs/Dashi/modules/event.lua:195Describe the bug
How to reproduce
What did you expect?
Screenshots
Hey,
Author of BetterBags here. I'm not sure why this error happens, but happy to offer any information that may help.
The slot's item tooltip doesn't have any points (not anchored) once TooltipDataProcessor.AddTooltipPostCall(Enum.TooltipDataType.Item, cb) is triggered.
I see you're based off ContainerFrameItemButtonTemplate, which shouldn't have any issues, so I don't know exactly why this happens.
I can add a check for it, forcing the Molinari tooltip to default anchor right, but you should maybe make sure that your slots have correct anchors once they're displayed.
Edit: Ignore this assumption, see below.
Thank you for the quick response. I am sure Cidan will comment when he see this.
Installed BetterBags and I see why it's not working.
Your slots are in a scrollframe, Molinari can't anchor to them directly.
This is the actual error:
1x Molinari/addon.lua:130: Action[SetPoint] failed because[Failure]: attempted from: Molinari:SetAllPoints.
[string "=[C]"]: in function `SetAllPoints'
[string "@Molinari/addon.lua"]:130: in function <Molinari/addon.lua:120>
[string "=[C]"]: ?
[string "=[C]"]: in function `Show'
[string "@Molinari/addon.lua"]:75: in function <Molinari/addon.lua:56>
[string "=(tail call)"]: ?
[string "@Molinari/utils.lua"]:20: in function <Molinari/utils.lua:5>
[string "=(tail call)"]: ?
[string "=[C]"]: in function `securecallfunction'
[string "@SharedXML/Tooltip/TooltipDataHandler.lua"]:162: in function <SharedXML/Tooltip/TooltipDataHandler.lua:157>
[string "@SharedXML/Tooltip/TooltipDataHandler.lua"]:182: in function <SharedXML/Tooltip/TooltipDataHandler.lua:178>
[string "@SharedXML/Tooltip/TooltipDataHandler.lua"]:218: in function <SharedXML/Tooltip/TooltipDataHandler.lua:208>
[string "=[C]"]: in function `SetAttribute'
[string "@SharedXML/Tooltip/TooltipDataHandler.lua"]:243: in function <SharedXML/Tooltip/TooltipDataHandler.lua:236>
[string "@SharedXML/Tooltip/TooltipDataHandler.lua"]:389: in function <SharedXML/Tooltip/TooltipDataHandler.lua:339>
[string "=[C]"]: in function `securecallfunction'
[string "@SharedXML/Tooltip/TooltipDataHandler.lua"]:336: in function <SharedXML/Tooltip/TooltipDataHandler.lua:335>
[string "=(tail call)"]: ?
[string "@FrameXML/ContainerFrame.lua"]:1519: in function `UpdateTooltip'
[string "@FrameXML/GameTooltip.lua"]:600: in function <FrameXML/GameTooltip.lua:593>
Locals:
(*temporary) = Molinari {
0 = <userdata>
ApplySpell = <function> defined @Molinari/addon.lua:56
IsEventRegistered = <function> defined @Dashi/modules/event.lua:76
TriggerCombatEvent = <function> defined @Dashi/modules/event.lua:222
RegisterCombatEvent = <function> defined @Dashi/modules/event.lua:227
RegisterUnitEvent = <function> defined @Dashi/modules/event.lua:119
UnregisterUnitEvent = <function> defined @Dashi/modules/event.lua:151
TriggerEvent = <function> defined @Dashi/modules/event.lua:89
RegisterEvent = <function> defined @Dashi/modules/event.lua:40
TriggerUnitEvent = <function> defined @Dashi/modules/event.lua:196
UnregisterCombatEvent = <function> defined @Dashi/modules/event.lua:245
ApplyItem = <function> defined @Molinari/addon.lua:79
IsUnitEventRegistered = <function> defined @Dashi/modules/event.lua:176
AddSparkles = <function> defined @Molinari/addon.lua:91
CalculateAction = <function> defined @FrameXML/SecureTemplates.lua:609
sparkles = <table> {
}
UnregisterEvent = <function> defined @Dashi/modules/event.lua:58
UpdateAttributeDriver = <function> defined @Molinari/addon.lua:96
}
(*temporary) = BetterBagsItemButton269 {
0 = <userdata>
OnLeave = <function> defined @FrameXML/ContainerFrame.lua:1493
SetItem = <function> defined @FrameXML/ItemButtonTemplate.lua:544
IconOverlay = Texture {
}
OnHide = <function> defined @FrameXML/ContainerFrame.lua:1585
__MSQ_bType = "Item"
SetAlpha = <function> defined @FrameXML/ItemButtonTemplate.lua:631
UpdateCooldown = <function> defined @FrameXML/ContainerFrame.lua:1704
ItemSlotBackground = Texture {
}
showMatchHighlight = true
OnDragStart = <function> defined @FrameXML/ContainerFrame.lua:1591
OnReceiveDrag = <function> defined @FrameXML/ContainerFrame.lua:1595
icon = BetterBagsItemButton269IconTexture {
}
SetItemButtonQuality = <function> defined @FrameXML/ItemButtonTemplate.lua:662
isExtended = false
__MSQ_SetItemButtonTexture = true
UpdateTooltip = <function> defined @FrameXML/ContainerFrame.lua:1504
SetReadable = <function> defined @FrameXML/ContainerFrame.lua:1696
CheckUpdateTooltip = <function> defined @FrameXML/ContainerFrame.lua:1720
__MSQ_Scale = 1
UpdateNewItem = <function> defined @FrameXML/ContainerFrame.lua:1642
IsReadable = <function> defined @FrameXML/ContainerFrame.lua:1700
PostOnEvent = <function> defined @FrameXML/ItemButtonTemplate.lua:427
__MSQ_PushedColor = <table> {
}
count = 1
UpdateItemContextMatching = <function> defined @FrameXML/ItemButtonTemplate.lua:450
__MSQ_Normal = Texture {
}
SetItemButtonCount = <function> defined @FrameXML/ItemButtonTemplate.lua:614
JunkIcon = Texture {
}
SetItemInternal = <function> defined @FrameXML/ItemButtonTemplate.lua:549
__MSQ_NormalSkin = <table> {
}
UpdateCraftedProfessionsQualityShown = <function> defined @FrameXML/ItemButtonTemplate.lua:461
HighlightTexture = Texture {
}
SetNormalAtlas = <function> defined =[C]:-1
__MSQ_NormalHook = true
PostOnShow = <function> defined @FrameXML/ItemButtonTemplate.lua:414
UpdateItemContextOverlayTextures = <function> defined @FrameXML/ItemButtonTemplate.lua:499
__MSQ_Enabled = true
SetItemSource = <function> defined @FrameXML/ItemButtonTemplate.lua:528
__MSQ_NormalColor = <table> {
}
__MSQ_NewNormal = Texture {
}
IconQuestTexture = BetterBagsItemButton269IconQuestTexture {
}
hasItem = 1
flash = Texture {
}
SetBagID = <function> defined @FrameXML/ContainerFrame.lua:1599
IsExtended = <function> defined @FrameXML/ContainerFrame.lua:1734
__MSQ_Skin = <table> {
}
UpdateItemContextOverlay = <function> defined @Interfac
Oh that's interesting -- why would a scroll frame cause this, and is there anything I can do to help?
I can't remove the scroll frame, as it's needed for one of the features of BetterBag.
@Thunderpain try out this alpha version please:
https://github.com/p3lim-wow/Molinari/actions/runs/7304996642/artifacts/1132110023
Calculate anchors since addons can be weird
Accurate.
Thank you for taking a look at this!
@Thunderpain try out this alpha version please: https://github.com/p3lim-wow/Molinari/actions/runs/7304996642/artifacts/1132110023
Trying it now!